docs: rewrite quickstart.md #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #884 +/- ##
==========================================
- Coverage 78.37% 78.33% -0.04%
==========================================
Files 40 40
Lines 14783 14765 -18
==========================================
- Hits 11586 11566 -20
- Misses 2509 2511 +2
Partials 688 688 |
kennytm
reviewed
Jun 3, 2020
docs/quickstart.md
Outdated
| > Here are a few things you might want to know: | ||
| > - To use a parser, a `parser_driver` is required. It decides how to parse the basic data types in SQL. | ||
| > | ||
| > You can use `github.com/pingcap/parser/test_driver` as the `parser_driver` for test. Again, if you need advanced features, please use the `test_driver` in TiDB(`go get -v github.com/pingcap/tidb/types/parser_driver@v4.0.0-rc.1` and import it). |
There was a problem hiding this comment.
Suggested change
| > You can use `github.com/pingcap/parser/test_driver` as the `parser_driver` for test. Again, if you need advanced features, please use the `test_driver` in TiDB(`go get -v github.com/pingcap/tidb/types/parser_driver@v4.0.0-rc.1` and import it). | |
| > You can use `github.com/pingcap/parser/test_driver` as the `parser_driver` for test. Again, if you need advanced features, please use the `test_driver` in TiDB (`go get -v github.com/pingcap/tidb/types/parser_driver@v4.0.0-rc.1` and import it). |
BTW why 4.0.0-rc.1 ?
There was a problem hiding this comment.
I found the latest released parser version is 4.0.0-rc.1.
3822be1 to
f9486ef
Compare
ran-huang
reviewed
Jun 28, 2020
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
tangenta
commented
Jun 28, 2020
Co-authored-by: Ran <huangran@pingcap.com>
tangenta
commented
Jun 28, 2020
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
ran-huang
approved these changes
Jun 28, 2020
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
As mentioned in #812, #788, and a few other issues, it is not easy to quickstart with parser. This PR rewrites
quickstart.mdby giving an example of parsing SQL text and traversing AST nodes.What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes