Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix type of MaxInt64 #251

Merged
merged 3 commits into from
Mar 25, 2019
Merged

*: fix type of MaxInt64 #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b6c9284
Fix int64_max
wjhuang2016 Mar 20, 2019
868d570
Add test
wjhuang2016 Mar 21, 2019
8376ffa
Merge branch 'master' into fix_int64max
crazycs520 Mar 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions parser_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,24 @@ func (s *testParserSuite) TestSimple(c *C) {
src = `insert into tb(v) (select v from tb);`
_, err = parser.ParseOneStmt(src, "", "")
c.Assert(err, IsNil)

// for issue #9823
src = "SELECT 9223372036854775807;"
st, err = parser.ParseOneStmt(src, "", "")
c.Assert(err, IsNil)
sel, ok := st.(*ast.SelectStmt)
c.Assert(ok, IsTrue)
expr := sel.Fields.Fields[0]
vExpr := expr.Expr.(*driver.ValueExpr)
c.Assert(vExpr.Kind(), Equals, types.KindInt64)
src = "SELECT 9223372036854775808;"
st, err = parser.ParseOneStmt(src, "", "")
c.Assert(err, IsNil)
sel, ok = st.(*ast.SelectStmt)
c.Assert(ok, IsTrue)
expr = sel.Fields.Fields[0]
vExpr = expr.Expr.(*driver.ValueExpr)
c.Assert(vExpr.Kind(), Equals, types.KindUint64)
}

type testCase struct {
Expand Down
2 changes: 1 addition & 1 deletion yy_parser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ func toInt(l yyLexer, lval *yySymType, str string) int {
}

switch {
case n < math.MaxInt64:
case n <= math.MaxInt64:
lval.item = int64(n)
default:
lval.item = n
Expand Down