executor: add builtin aggregate function json_arrayagg
#1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@SunRunAway,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: ddl(slack). |
|
@arthuryangcs Please resolve the confliting files. |
cb98f2c to
07f2fc3
Compare
Resolved. |
07f2fc3 to
e686464
Compare
|
@SunRunAway @kennytm Please review the code. |
|
@SunRunAway @kennytm Please review the code. |
ti-srebot
approved these changes
Sep 22, 2020
|
/merge |
|
/run-all-tests |
|
@arthuryangcs merge failed. |
|
/merge |
|
@arthuryangcs Oops! auto merge is restricted to Committers of the SIG.See the corresponding SIG page for more information. Related SIG: ddl(slack). |
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
pingcap/tidb#7623
What is changed and how it works?
add an json_arrayagg function
Check List
[] Make sure the replace instruction is changed back to the required instruction and the version is the latest.
Tests
{`select json_arrayagg(c2) from t group by c1`, true, "SELECT JSON_ARRAYAGG(`c2`) FROM `t` GROUP BY `c1`"}, {`select json_arrayagg(c1, c2) from t group by c1`, false, ""}, {`select json_arrayagg(distinct c2) from t group by c1`, false, "SELECT JSON_ARRAYAGG(DISTINCT `c2`) FROM `t` GROUP BY `c1`"}, {`select json_arrayagg(all c2) from t group by c1`, true, "SELECT JSON_ARRAYAGG(`c2`) FROM `t` GROUP BY `c1`"},Code changes
JSON_ARRAYAGGRelated changes
json_arrayaggtidb#19957