make With fields surrounding with []
#4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolouch
reviewed
Mar 5, 2019
zap_log_test.go
Outdated
| `[INFO] [zap_log_test.go:127] [欢迎]`, | ||
| `[INFO] [zap_log_test.go:128] ["欢迎来到 TiDB"]`, | ||
| `[WARN] [zap_log_test.go:129] [Type] [Counter=NaN] [Score=+Inf]`, | ||
| `[INFO] [zap_log_test.go:133] ["new connection"],[connID=1] [traceID=dse1121]`, |
There was a problem hiding this comment.
it seems we should change this https://github.com/pingcap/log/pull/4/files#diff-22234ef75ee1f622759c3325ab0a28deR434
zz-jason
reviewed
Mar 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3
because uber-go/zap#685 can not be accepted in 1.x and too many private method, so we temp copy whole ioCore to pingcap/log to call our
addFileds()then we can make pingcap/tidb#9548 works
This change is