Add start_ts field into kvrpcpb.Context #1073
Conversation
Signed-off-by: JmPotato <ghzpotato@gmail.com>
c2ae1b7 to
d678029
Compare
| @@ -845,6 +845,9 @@ message Context { | |||
| // error before processing if the estimated waiting duration exceeds the threshold. | |||
| uint32 busy_threshold_ms = 27; | |||
|
|
|||
| // The `start_ts` of the transaction that the request belongs to. | |||
| uint64 start_ts = 28; | |||
There was a problem hiding this comment.
I notice a lot of requests already have a start_version field. Why bother to add one more in context?
There was a problem hiding this comment.
After digging into the code, I think adding a start_ts field is the simplest way to get it passed into the place where the resource control works at.
Please take a look at https://github.com/tikv/client-go/pull/732/files#diff-34812587e42268a5d84933be286601fc58fdff17ab336b09ba75455ffe5ed447R47. tikvrpc.Request contains kvrpcpb.Context.
There was a problem hiding this comment.
But you can get the start ts from tikvrpc.Request by a type matching
There was a problem hiding this comment.
Make sense. Let me try it out.
There was a problem hiding this comment.
BTW, The PointGet may use max_ts? Will this affect the result?
There was a problem hiding this comment.
I double-checked the code of TiDB and think it's not a problem. Here is the reason: tikv/client-go#732 (comment).
|
/hold |
Ref pingcap/tidb#41972, tikv/client-go#732.