Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

information-schema: add client errors docs #5062

Merged
merged 17 commits into from
Apr 7, 2021
Merged

information-schema: add client errors docs #5062

merged 17 commits into from
Apr 7, 2021

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Mar 18, 2021

What is changed, added or deleted? (Required)

This adds docs for pingcap/tidb#22382

Currently this is in master and v5.0, but the cherry pick for 4.0 is also pending. It is required for 4.0 to observe a security issue.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 18, 2021
@morgo morgo mentioned this pull request Mar 18, 2021
Merged
@TomShawn
Copy link
Contributor

/cc @bb7133 @djshow832
/size large
/translation doing
/status PTAL

@ti-chi-bot ti-chi-bot requested review from bb7133 and djshow832 March 19, 2021 03:44
@ti-chi-bot ti-chi-bot added size/large Changes of a large size. translation/doing This PR's assignee is translating this PR. status/PTAL This PR is ready for reviewing. and removed missing-translation-status This PR does not have translation status info. labels Mar 19, 2021
@TomShawn
Copy link
Contributor

/label needs-cherry-pick-5.0

@ti-srebot
Copy link
Contributor

@bb7133, @djshow832, PTAL.

1 similar comment
@ti-srebot
Copy link
Contributor

@bb7133, @djshow832, PTAL.

@bb7133
Copy link
Member

bb7133 commented Mar 23, 2021

/lgtm

@ti-chi-bot
Copy link
Member

@bb7133: /lgtm is only allowed for the reviewers in list.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@bb7133
Copy link
Member

bb7133 commented Mar 25, 2021

/label sig/sql-infra

@ti-chi-bot
Copy link
Member

@bb7133: The label(s) sig/sql-infra cannot be applied. These labels are supported: Hacktoberfest, contribution, first-time-contributor, requires-followup, good-first-issue, hacktoberfest-accepted, help-wanted, needs-cherry-pick-2.1, needs-cherry-pick-3.0, needs-cherry-pick-3.1, needs-cherry-pick-4.0, needs-cherry-pick-5.0, needs-cherry-pick-master, question, require-LGT1, require-LGT2, require-LGT3, special-week, v4.0, v5.0, for-future-release, requires-version-specific-changes, website.

In response to this:

/label sig/sql-infra

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@yikeke yikeke added the v5.0 This PR/issue applies to TiDB v5.0. label Mar 31, 2021
TomShawn
TomShawn reviewed Apr 1, 2021
View reviewed changes
@ti-chi-bot ti-chi-bot added status/require-change Needs the author to address comments. and removed status/PTAL This PR is ready for reviewing. labels Apr 1, 2021
@ti-chi-bot
Copy link
Member

@TomShawn: These labels are not set on the issue: status/ptal.

In response to this:

/remove-status PTAL
/status require-change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@bb7133
Copy link
Member

bb7133 commented Apr 2, 2021

/uncc bb7133

@ti-chi-bot ti-chi-bot removed the request for review from bb7133 April 2, 2021 09:52
@ti-srebot
Copy link
Contributor

@morgo, please update your pull request.

1 similar comment
@ti-srebot
Copy link
Contributor

@morgo, please update your pull request.

TomShawn
TomShawn reviewed Apr 6, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

morgo and others added 8 commits April 6, 2021 16:22
@morgo @TomShawn
Update information-schema/client-errors-summary-by-host.md
b4c314d 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@morgo @TomShawn
Update information-schema/client-errors-summary-by-host.md
b304697 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@morgo @TomShawn
Update information-schema/client-errors-summary-by-user.md
feca9d7 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@morgo @TomShawn
Update information-schema/client-errors-summary-global.md
5474f5a 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@morgo @TomShawn
Update information-schema/client-errors-summary-by-user.md
a0b8ad6 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@morgo @TomShawn
Update information-schema/client-errors-summary-global.md
0efec3c 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@morgo @TomShawn
Update information-schema/client-errors-summary-by-user.md
c07bc84 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@morgo @TomShawn
Update information-schema/client-errors-summary-by-user.md
f4e2958 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn
Copy link
Contributor

TomShawn commented Apr 7, 2021

/remove-status require-change
/label require-LGT1
/lgtm

@ti-chi-bot ti-chi-bot added require-LGT1 Indicates that the PR requires an LGTM. and removed status/require-change Needs the author to address comments. labels Apr 7, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 7, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Apr 7, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f4e2958

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 7, 2021
@ti-chi-bot ti-chi-bot merged commit 760bfcf into pingcap:master Apr 7, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 7, 2021
@morgo @ti-srebot
cherry pick pingcap#5062 to release-5.0
d82e7aa 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 7, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5229

ti-chi-bot pushed a commit that referenced this pull request Apr 7, 2021
@ti-srebot
information-schema: add client errors docs (#5062) (#5229)
b61213b
@Joyinqin Joyinqin mentioned this pull request Apr 7, 2021
Merged
11 tasks
@Joyinqin
Copy link
Contributor

Joyinqin commented Apr 7, 2021

/translation done

@ti-chi-bot ti-chi-bot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Apr 7, 2021
@Joyinqin
Copy link
Contributor

Joyinqin commented Apr 7, 2021

/remove-translation doing

@ti-chi-bot ti-chi-bot removed the translation/doing This PR's assignee is translating this PR. label Apr 7, 2021
@lilin90 lilin90 mentioned this pull request Apr 7, 2021
Merged
10 tasks
This was referenced Apr 7, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn left review comments

@djshow832 djshow832 Awaiting requested review from djshow832

Assignees

@Joyinqin Joyinqin

Labels
require-LGT1 Indicates that the PR requires an LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v5.0 This PR/issue applies to TiDB v5.0.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@morgo @TomShawn @ti-srebot @bb7133 @ti-chi-bot @Joyinqin @yikeke