-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql-statements: document BACKUP, RESTORE and SHOW [BACKUPS|RESTORES] #2618
Conversation
cc @bb7133 |
No need to add the needs-cherry-pick-4.0 label bacause the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use color #D0E2F3
for the sql diagrams, as in other docs.
@djshow832 what tools can you use to generate the sqlgram with that color? The sqlgram generated by https://github.com/pingcap/sqlgram/tree/gh-pages/tools/sg is black-and-white as this PR presented. |
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Please update the sqlgram, LGTM for the rest. |
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@kennytm Please follow up on replacing the sqlgram images after this PR is merged, thanks! |
/merge |
/run-all-tests |
* Update command line flags for pd configruation (#2596) Signed-off-by: nolouch <nolouch@gmail.com> * Remove upgrade-tiflash.md (#2597) * Remove upgrade-tiflash.md Duplicated with TiDB's upgrade manual. * delete a link Co-authored-by: yikeke <yikeke@pingcap.com> * Move TiFlash troubleshoot part to a new document (#2602) * best-practice: update massive regions to match 4.0 (#2595) Signed-off-by: Jay Lee <BusyJayLee@gmail.com> * sql-statements: document BACKUP, RESTORE and SHOW [BACKUPS|RESTORES] (#2618) Co-authored-by: ShuNing <nolouch@gmail.com> Co-authored-by: Flowyi <flowbehappy@gmail.com> Co-authored-by: lei yu <leiysky@outlook.com> Co-authored-by: Jay <BusyJay@users.noreply.github.com> Co-authored-by: kennytm <kennytm@gmail.com>
What is changed, added or deleted? (Required)
Document the following SQL statements for 4.0:
Which TiDB version(s) do your changes apply to? (Required)
If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.
What is the related PR or file link(s)?