Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql-statements: document BACKUP, RESTORE and SHOW [BACKUPS|RESTORES] #2618

Merged
merged 11 commits into from
May 28, 2020

Conversation

kennytm
Copy link
Contributor

@kennytm kennytm commented May 26, 2020

What is changed, added or deleted? (Required)

Document the following SQL statements for 4.0:

  • BACKUP
  • RESTORE
  • SHOW BACKUPS
  • SHOW RESTORES

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@kennytm kennytm added needs-cherry-pick-4.0 status/PTAL This PR is ready for reviewing. labels May 26, 2020
@sre-bot sre-bot added special-week PR from Document Special Week. translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels May 26, 2020
@sre-bot sre-bot requested review from kissmydb and lilin90 May 26, 2020 08:32
@kennytm
Copy link
Contributor Author

kennytm commented May 26, 2020

cc @bb7133

@yikeke
Copy link
Contributor

yikeke commented May 26, 2020

No need to add the needs-cherry-pick-4.0 label bacause the docs-special-week base branch will be merged to master and release-4.0 branches as a whole. FYI @kennytm

@yikeke yikeke requested a review from bb7133 May 26, 2020 08:34
@kennytm kennytm force-pushed the kennytm/sql-brie branch from 74f122f to 1fc4a72 Compare May 26, 2020 09:52
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use color #D0E2F3 for the sql diagrams, as in other docs.

@kennytm
Copy link
Contributor Author

kennytm commented May 26, 2020

@djshow832 what tools can you use to generate the sqlgram with that color? The sqlgram generated by https://github.com/pingcap/sqlgram/tree/gh-pages/tools/sg is black-and-white as this PR presented.

kennytm and others added 2 commits May 28, 2020 00:08
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@bb7133
Copy link
Member

bb7133 commented May 28, 2020

@djshow832 what tools can you use to generate the sqlgram with that color? The sqlgram generated by https://github.com/pingcap/sqlgram/tree/gh-pages/tools/sg is black-and-white as this PR presented.

Please update the sqlgram, LGTM for the rest.

@TomShawn TomShawn added the status/require-change Needs the author to address comments. label May 28, 2020
kennytm and others added 3 commits May 28, 2020 14:07
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn added requires-followup This PR requires a follow-up task after being merged. and removed status/PTAL This PR is ready for reviewing. status/require-change Needs the author to address comments. labels May 28, 2020
@TomShawn
Copy link
Contributor

@kennytm Please follow up on replacing the sqlgram images after this PR is merged, thanks!

@TomShawn
Copy link
Contributor

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 28, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 28, 2020

/run-all-tests

@sre-bot sre-bot merged commit 659b09c into docs-special-week May 28, 2020
yikeke added a commit that referenced this pull request May 28, 2020
* Update command line flags for pd configruation (#2596)

Signed-off-by: nolouch <nolouch@gmail.com>

* Remove upgrade-tiflash.md (#2597)

* Remove upgrade-tiflash.md

Duplicated with TiDB's upgrade manual.

* delete a link

Co-authored-by: yikeke <yikeke@pingcap.com>

* Move TiFlash troubleshoot part to a new document (#2602)

* best-practice: update massive regions to match 4.0 (#2595)

Signed-off-by: Jay Lee <BusyJayLee@gmail.com>

* sql-statements: document BACKUP, RESTORE and SHOW [BACKUPS|RESTORES] (#2618)

Co-authored-by: ShuNing <nolouch@gmail.com>
Co-authored-by: Flowyi <flowbehappy@gmail.com>
Co-authored-by: lei yu <leiysky@outlook.com>
Co-authored-by: Jay <BusyJay@users.noreply.github.com>
Co-authored-by: kennytm <kennytm@gmail.com>
@TomShawn TomShawn self-requested a review May 31, 2020 03:59
@yikeke yikeke added translation/doing This PR's assignee is translating this PR. and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jun 11, 2020
@lilin90 lilin90 deleted the kennytm/sql-brie branch June 18, 2020 03:06
@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires-followup This PR requires a follow-up task after being merged. special-week PR from Document Special Week. status/can-merge Indicates a PR has been approved by a committer. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants