-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Update LinkChecker URL excludes #20287
Conversation
With this:
The above is with the blanked exclude for github.com in place. Questions etc:
|
I've replaced some HTML tables with markdown tables. And same for HTML |
This is not a false positive, it really is a broken link, but I don't know what it should be corrected to. |
In link-fail-fast.yaml, the GitHub API token is already used for the link validation requests. https://github.com/pingcap/docs/blob/master/.github/workflows/link-fail-fast.yaml#L31 |
internals.tidb.io is now inaccessible. The alternative option is github.com/orgs/pingcap/discussions according to @wuhuizuo. I've created #20294 to update the link. |
Once everything is completed this should help to monitor it: https://github.com/pingcap/docs/blob/master/.github/workflows/link.yaml |
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What is changed, added or deleted? (Required)
The aim is to reduce false positive in the link checker
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?