Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serverless import gcs/azure #20230

Merged
merged 10 commits into from
Feb 19, 2025
Merged

serverless import gcs/azure #20230

merged 10 commits into from
Feb 19, 2025

Conversation

xuanyu66
Copy link

@xuanyu66 xuanyu66 commented Feb 11, 2025 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. missing-translation-status This PR does not have translation status info. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 11, 2025
@xuanyu66 xuanyu66 added area/tidb-cloud This PR relates to the area of TiDB Cloud. for-cloud-release This PR is related to TiDB Cloud release. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed missing-translation-status This PR does not have translation status info. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 11, 2025
@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 11, 2025
@Oreoxmt Oreoxmt self-assigned this Feb 11, 2025
@Oreoxmt Oreoxmt self-requested a review February 11, 2025 07:11
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Feb 11, 2025

@xuanyu66 Please add these files to TOC-tidb-cloud.md:

  • tidb-cloud/import-csv-files-serverless.md
  • tidb-cloud/import-parquet-files-serverless.md
  • tidb-cloud/import-sample-data-serverless.md
  • tidb-cloud/import-snapshot-files-serverless.md
  • tidb-cloud/import-with-mysql-cli-serverless.md

@xuanyu66 xuanyu66 marked this pull request as draft February 11, 2025 07:30
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 11, 2025
@xuanyu66
Copy link
Author

@xuanyu66 Please add these files to TOC-tidb-cloud.md:

  • tidb-cloud/import-csv-files-serverless.md
  • tidb-cloud/import-parquet-files-serverless.md
  • tidb-cloud/import-sample-data-serverless.md
  • tidb-cloud/import-snapshot-files-serverless.md
  • tidb-cloud/import-with-mysql-cli-serverless.md

OK, when the PR is ready, I will let you know.

@xuanyu66 xuanyu66 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 11, 2025
@xuanyu66 xuanyu66 force-pushed the serverless-import-gcs/azure branch 2 times, most recently from d48c329 to 58b312c Compare February 11, 2025 12:32
@xuanyu66 xuanyu66 marked this pull request as ready for review February 12, 2025 07:47
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 12, 2025
@xuanyu66
Copy link
Author

@Oreoxmt PTAL

github-actions bot pushed a commit to Oreoxmt/pingcap-docsite-preview that referenced this pull request Feb 12, 2025
Preview PR pingcap/docs#20230 and this preview is triggered from commit
799a55a 
pingcap/docs@894fc79
github-actions bot pushed a commit to Oreoxmt/pingcap-docsite-preview that referenced this pull request Feb 17, 2025
Preview PR pingcap/docs#20230 and this preview is triggered from commit
4468b69 
pingcap/docs@9815519
@Oreoxmt Oreoxmt added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2025
@hfxsd hfxsd self-requested a review February 17, 2025 06:58
@xuanyu66
Copy link
Author

/retest

@Oreoxmt Oreoxmt self-requested a review February 17, 2025 08:44
hfxsd
hfxsd reviewed Feb 18, 2025
View reviewed changes
@Oreoxmt @hfxsd
Apply suggestions from code review
39fe76f 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 18, 2025
@Oreoxmt @hfxsd
Apply suggestions from code review
989b765 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
Oreoxmt
Oreoxmt approved these changes Feb 18, 2025
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 18, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 18, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-18 02:30:25.3583435 +0000 UTC m=+928467.754565554: ☑️ agreed by hfxsd.
  • 2025-02-18 02:32:45.703354329 +0000 UTC m=+928608.099576394: ☑️ agreed by Oreoxmt.

@xuanyu66 @hfxsd @Oreoxmt
Apply suggestions from code review
95e5e23 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
Co-authored-by: Aolin <aolin.zhang@pingcap.com>
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Feb 19, 2025

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 19, 2025
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Feb 19, 2025

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 19, 2025
@ti-chi-bot ti-chi-bot bot merged commit a0eb271 into release-8.1 Feb 19, 2025
8 of 9 checks passed
@Oreoxmt Oreoxmt deleted the serverless-import-gcs/azure branch February 19, 2025 02:26
github-actions bot pushed a commit to Oreoxmt/pingcap-docsite-preview that referenced this pull request Feb 19, 2025
Preview PR pingcap/docs#20230 and this preview is triggered from commit
f3c645a 
pingcap/docs@95e5e23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfxsd hfxsd hfxsd approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
approved area/tidb-cloud This PR relates to the area of TiDB Cloud. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. for-cloud-release This PR is related to TiDB Cloud release. lgtm size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xuanyu66 @Oreoxmt @hfxsd @zhangyangyu