Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

select: Add tablesample #12979

Merged
merged 8 commits into from
May 4, 2023
Merged

select: Add tablesample #12979

merged 8 commits into from
May 4, 2023

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Mar 20, 2023

What is changed, added or deleted? (Required)

Closes #5915

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Example

sql> SELECT * FROM item TABLESAMPLE REGIONS();
+------+---------+-------------------------+---------+------------------------------------------+
| i_id | i_im_id | i_name                  | i_price | i_data                                   |
+------+---------+-------------------------+---------+------------------------------------------+
|    1 |    6138 | 1Md6YJgZCYlcpfBkWmOJzmS |   11.38 | 99AZzeYO7GIi0Q9bgufHVwXVzMYxdIOa3pr3Guia |
+------+---------+-------------------------+---------+------------------------------------------+
1 row in set (0.0014 sec)

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 20, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tangenta
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from ran-huang March 20, 2023 16:08
@dveeden dveeden requested review from qiancai and removed request for ran-huang March 20, 2023 16:08
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 20, 2023
@dveeden dveeden requested review from tangenta and tiancaiamao March 20, 2023 16:08
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 21, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 23, 2023
@dveeden dveeden requested a review from qiancai April 11, 2023 09:23
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 11, 2023
Co-authored-by: Grace Cai <qqzczy@126.com>
@qiancai qiancai added the translation/doing This PR's assignee is translating this PR. label Apr 22, 2023
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Apr 22, 2023
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 25, 2023
@ran-huang ran-huang added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-6.6 labels May 4, 2023
@ran-huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 4, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 415584a

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 4, 2023
@ti-chi-bot ti-chi-bot bot merged commit bcf2ec4 into pingcap:master May 4, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request May 4, 2023
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #13397.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request May 4, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request May 4, 2023
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #13398.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request May 4, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request May 4, 2023
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.6: #13399.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request May 4, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request May 4, 2023
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.0: #13400.

ti-chi-bot bot pushed a commit that referenced this pull request May 4, 2023
ti-chi-bot bot pushed a commit that referenced this pull request May 4, 2023
ti-chi-bot bot pushed a commit that referenced this pull request May 4, 2023
ti-chi-bot bot pushed a commit that referenced this pull request May 4, 2023
@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TABLESAMPLE is missing from docs
6 participants