Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TLS Connect to Serverless Tier of TiDB Cloud #11944

Merged
merged 23 commits into from
Jan 16, 2023
Merged

Update TLS Connect to Serverless Tier of TiDB Cloud #11944

merged 23 commits into from
Jan 16, 2023

Conversation

lulukelu
Copy link

@lulukelu lulukelu commented Jan 9, 2023 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 9, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 9, 2023
Daemonxiao
Daemonxiao reviewed Jan 9, 2023
View reviewed changes
@shichun-0415 shichun-0415 added translation/no-need No need to translate this PR. area/tidb-cloud This PR relates to the area of TiDB Cloud. labels Jan 9, 2023
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jan 9, 2023
@lulukelu @zhangyangyu @Daemonxiao
Apply suggestions from code review
a749bca 
Co-authored-by: Xiang Zhang <angwerzx@126.com>
Co-authored-by: Daemonxiao <35677990+Daemonxiao@users.noreply.github.com>
@lulukelu @qiancai @ran-huang
Apply suggestions from code review
2767924 
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Ran <huangran.alex@gmail.com>
@qiancai qiancai added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Jan 12, 2023
@lulukelu @zhangyangyu
Apply suggestions from code review
9e9f9aa 
Co-authored-by: Xiang Zhang <angwerzx@126.com>
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2023
ran-huang
ran-huang approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 13, 2023
@lulukelu @ran-huang @qiancai
Apply suggestions from code review
ae6c762 
Co-authored-by: Ran <huangran.alex@gmail.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 16, 2023
qiancai
qiancai approved these changes Jan 16, 2023
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qiancai
Copy link
Collaborator

qiancai commented Jan 16, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 08c1db3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 16, 2023
@ti-chi-bot ti-chi-bot merged commit 1fdfa46 into pingcap:release-6.1 Jan 16, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 16, 2023
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #12052.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Jan 16, 2023
@lulukelu @ti-chi-bot
Update TLS Connect to Serverless Tier of TiDB Cloud (pingcap#11944)
81cdba7
ti-chi-bot added a commit that referenced this pull request Jan 16, 2023
@ti-chi-bot
Update TLS Connect to Serverless Tier of TiDB Cloud (#11944) (#12052)
b2fbbdb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Daemonxiao Daemonxiao Daemonxiao left review comments

@zhangyangyu zhangyangyu zhangyangyu approved these changes

@ran-huang ran-huang ran-huang approved these changes

@qiancai qiancai qiancai approved these changes

@ljun0712 ljun0712 ljun0712 approved these changes

Assignees
No one assigned
Labels
area/tidb-cloud This PR relates to the area of TiDB Cloud. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/no-need No need to translate this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@lulukelu @ti-chi-bot @qiancai @zhangyangyu @Daemonxiao @ran-huang @ljun0712 @shichun-0415