Skip to content
This repository has been archived by the owner on Jan 3, 2025. It is now read-only.

en: add clean-dump-file configuration (#184) #187

Merged
merged 2 commits into from
Jul 27, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #184 to release-1.0


What is changed, added or deleted? (Required)

add configuration introduced by pingcap/dm#804

Which DM version(s) do your changes apply to? (Required)

  • master (the latest development version, including v2.0 changes for now)
  • v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added type/cherry-pick-for-release-1.0 This PR is cherry-picked to release-1.0 from a source PR. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. labels Jul 27, 2020
@ti-srebot
Copy link
Contributor Author

@toutdesuite please accept the invitation then you can push to the cherry-pick pull requests.
https://github.com/ti-srebot/docs-dm/invitations

@@ -30,7 +30,11 @@ meta-schema: "dm_meta" # The downstream database that stores the `meta`
remove-meta: false # Whether to remove the `meta` information (`checkpoint` and `onlineddl`) corresponding to the task name before starting the replication task.
enable-heartbeat: false # Whether to enable the heartbeat feature.
online-ddl-scheme: "gh-ost" # Only "gh-ost" and "pt" are currently supported.
<<<<<<< HEAD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@toutdesuite Please resolve the conflict by applying version-specific changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomShawn PTAL, thanks

Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 27, 2020
@TomShawn TomShawn merged commit e86ce50 into pingcap:release-1.0 Jul 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-1.0 This PR is cherry-picked to release-1.0 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants