Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for dynamic privileges #6407

Merged
merged 7 commits into from
Jun 8, 2021
Merged

Add docs for dynamic privileges #6407

merged 7 commits into from
Jun 8, 2021

Conversation

Joyinqin
Copy link
Contributor

@Joyinqin Joyinqin commented Jun 4, 2021 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

This feature documents pingcap/tidb#22778 which has not yet merged. It only applies to master, and fixes a couple of other small bugs (around password -> authentication_string).

The list of "Privileges required for TiDB operations" is changed to an example, because the list does not account for dynamic privileges so it gets confusing.

The PR includes comments for where the version after 5.0 will need to be inserted. Thus, the PR should be labeled as requiring followup after merging as well.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Joyinqin Joyinqin marked this pull request as draft June 4, 2021 06:48
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 4, 2021
@ti-chi-bot ti-chi-bot requested a review from TomShawn June 4, 2021 06:48
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 4, 2021
@Joyinqin Joyinqin added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. requires-followup This PR requires a follow-up task after being merged. sig/docs Indicates that the Issue or PR belongs to the docs SIG. area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. translation/from-docs This PR is translated from a PR in pingcap/docs. v5.1 This PR/issue applies to TiDB v5.1. labels Jun 4, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jun 4, 2021
@Joyinqin Joyinqin marked this pull request as ready for review June 7, 2021 01:49
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 7, 2021
@Joyinqin Joyinqin requested a review from bb7133 June 7, 2021 01:50
@bb7133
Copy link
Member

bb7133 commented Jun 7, 2021

/lgtm

@ti-chi-bot
Copy link
Member

@bb7133: Please use GitHub review feature instead of /lgtm [cancel] when you want to submit review to the pull request.
For how to use GitHub review feature, see also this document provided by GitHub.

For the reason we drop support to the commands, see also this page.
This reply is being used as a temporary reply during the migration of review process and will be removed on July 1st.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

TomShawn
TomShawn reviewed Jun 7, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update Line 487.

TomShawn
TomShawn approved these changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 8, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Jun 8, 2021

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Jun 8, 2021
@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jun 8, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Jun 8, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a4a6108

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 8, 2021
@TomShawn TomShawn removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 8, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Jun 8, 2021

/merge

@ti-chi-bot ti-chi-bot merged commit 8f435a6 into pingcap:master Jun 8, 2021
@Joyinqin Joyinqin deleted the dynamic-privilege branch June 9, 2021 02:22
@TomShawn TomShawn removed the requires-followup This PR requires a follow-up task after being merged. label Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@bb7133 bb7133 Awaiting requested review from bb7133

Assignees
No one assigned
Labels
area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. sig/docs Indicates that the Issue or PR belongs to the docs SIG. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs This PR is translated from a PR in pingcap/docs. v5.1 This PR/issue applies to TiDB v5.1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Joyinqin @bb7133 @ti-chi-bot @TomShawn