Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql-statements: use EBNF to render syntax diagrams - second batch (#5376) #5408

Closed

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jan 26, 2021

cherry-pick #5376 to release-3.1
You can switch your code base to this Pull Request by using git-extras:

# In docs-cn repo:
git pr https://github.com/pingcap/docs-cn/pull/5408

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/docs-cn.git pr/5408:release-3.1-541d0a6b1ba7

What is changed, added or deleted? (Required)

This PR changes the synopsis sections of BEGIN, CHANGE, COMMIT, CREATE, DEALLOCATE, DELETE, DO, and DROP statements to use the ```ebnf+diagrm block, replacing the original image-based sqlgrams. It is a follow-up PR to pingcap/docs#4389.

To avoid making one single PR too large, I will open 4-5 follow-up PRs to process sql-statements files in batches. And I will delete all image files in the last PR in case of any display issues.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added status/PTAL This PR is ready for reviewing. type/cherry-pick-for-release-3.1 This PR is cherry-picked to release-3.1 from a source PR. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. labels Jan 26, 2021
@ti-srebot ti-srebot requested review from kennytm and TomShawn January 26, 2021 09:22
@ti-srebot
Copy link
Contributor Author

@CharLotteiu you're already a collaborator in bot's repo.

@ti-srebot
Copy link
Contributor Author

@kennytm, @TomShawn, PTAL.

1 similar comment
@ti-srebot
Copy link
Contributor Author

@kennytm, @TomShawn, PTAL.

@CharLotteiu
Copy link
Contributor

Closed as we decided not to maintain the EBNF code of synopsis on the release-3.1 branch.

@CharLotteiu CharLotteiu closed this Feb 1, 2021
@TomShawn TomShawn removed status/PTAL This PR is ready for reviewing. type/cherry-pick-for-release-3.1 This PR is cherry-picked to release-3.1 from a source PR. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. labels Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants