Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: add switch for check constraint #14320

Merged
merged 7 commits into from
Jun 28, 2023
Merged

sql: add switch for check constraint #14320

merged 7 commits into from
Jun 28, 2023

Conversation

fzzf678
Copy link
Contributor

@fzzf678 fzzf678 commented Jun 27, 2023

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add a switch

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 27, 2023
@fzzf678
Copy link
Contributor Author

fzzf678 commented Jun 27, 2023

@CbcWestwolf please take a tech review

@qiancai qiancai added the translation/doing This PR’s assignee is translating this PR. label Jun 27, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jun 27, 2023
@qiancai qiancai added missing-translation-status This PR does not have translation status info. v7.2 This PR/issue applies to TiDB v7.2. labels Jun 27, 2023
@qiancai qiancai self-assigned this Jun 27, 2023
@qiancai qiancai self-requested a review June 27, 2023 01:29
@qiancai qiancai added area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. and removed missing-translation-status This PR does not have translation status info. labels Jun 27, 2023
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 27, 2023
TonsnakeLin
TonsnakeLin approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@TonsnakeLin TonsnakeLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after fixing it by the comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 27, 2023

@TonsnakeLin: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM after fixing it by the comment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fzzf678
Copy link
Contributor Author

fzzf678 commented Jun 27, 2023

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 27, 2023
@fzzf678
Copy link
Contributor Author

fzzf678 commented Jun 27, 2023

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 27, 2023
qiancai
qiancai reviewed Jun 27, 2023
View reviewed changes
qiancai
qiancai reviewed Jun 27, 2023
View reviewed changes
@fzzf678 @qiancai
Apply suggestions from code review
a89dcf4 
Co-authored-by: Grace Cai <qqzczy@126.com>
qiancai
qiancai reviewed Jun 27, 2023
View reviewed changes
@Oreoxmt Oreoxmt self-requested a review June 27, 2023 03:55
Oreoxmt
Oreoxmt reviewed Jun 27, 2023
View reviewed changes
Oreoxmt
Oreoxmt reviewed Jun 27, 2023
View reviewed changes
@qiancai @Oreoxmt
Apply suggestions from code review
e189d5a 
Co-authored-by: Aolin <aolinz@outlook.com>
Oreoxmt
Oreoxmt approved these changes Jun 27, 2023
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 27, 2023
@fzzf678 fzzf678 mentioned this pull request Jun 27, 2023
Merged
17 tasks
@qiancai qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 27, 2023
qiancai
qiancai reviewed Jun 28, 2023
View reviewed changes
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 28, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 28, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-27 05:57:57.450980303 +0000 UTC m=+687242.852230755: ☑️ agreed by Oreoxmt.
  • 2023-06-28 07:37:08.45444507 +0000 UTC m=+779593.855695519: ☑️ agreed by qiancai.

@qiancai qiancai added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-7.2 and removed lgtm labels Jun 28, 2023
@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 28, 2023
@qiancai
Copy link
Collaborator

qiancai commented Jun 28, 2023

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Jun 28, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 28, 2023
Merged
17 tasks
@qiancai
Copy link
Collaborator

qiancai commented Jun 28, 2023

/approve

@qiancai qiancai added the lgtm label Jun 28, 2023
@qiancai
Copy link
Collaborator

qiancai commented Jun 28, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 4f45ef2 into pingcap:master Jun 28, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 28, 2023
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.2: #14349.

ti-chi-bot bot pushed a commit that referenced this pull request Jun 28, 2023
@ti-chi-bot
sql: add switch for check constraint (#14320) (#14349)
ee9927e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@qiancai qiancai qiancai approved these changes

@TonsnakeLin TonsnakeLin TonsnakeLin approved these changes

Assignees

@qiancai qiancai

Labels
approved area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v7.2 This PR/issue applies to TiDB v7.2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fzzf678 @qiancai @ti-chi-bot @Oreoxmt @TonsnakeLin