Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tiflash execution tuning materials #12637

Merged
merged 19 commits into from
Jan 11, 2023
Merged

Add tiflash execution tuning materials #12637

merged 19 commits into from
Jan 11, 2023

Conversation

yibin87
Copy link
Contributor

@yibin87 yibin87 commented Jan 11, 2023

Signed-off-by: yibin huyibin@pingcap.com

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: yibin <huyibin@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 11, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from ran-huang January 11, 2023 02:52
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 11, 2023
@shichun-0415 shichun-0415 requested review from shichun-0415 and removed request for ran-huang January 11, 2023 02:55
@shichun-0415 shichun-0415 self-assigned this Jan 11, 2023
@yibin87 yibin87 requested a review from windtalker January 11, 2023 02:56
@shichun-0415 shichun-0415 added type/enhancement The issue or PR belongs to an enhancement. translation/doing This PR’s assignee is translating this PR. area/bigdata Indicates that the Issue or PR belongs to the area of TiFlash, TiSpark, and OLAP. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. and removed missing-translation-status This PR does not have translation status info. labels Jan 11, 2023
Signed-off-by: yibin <huyibin@pingcap.com>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 11, 2023
Signed-off-by: yibin <huyibin@pingcap.com>
Signed-off-by: yibin <huyibin@pingcap.com>
@yibin87 yibin87 removed the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Jan 11, 2023
Signed-off-by: yibin <huyibin@pingcap.com>
@yibin87 yibin87 requested a review from windtalker January 11, 2023 04:57
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: yibin <huyibin@pingcap.com>
Signed-off-by: yibin <huyibin@pingcap.com>
yibin87 and others added 3 commits January 11, 2023 13:59
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
Signed-off-by: yibin <huyibin@pingcap.com>
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
Signed-off-by: yibin <huyibin@pingcap.com>
@yibin87
Copy link
Contributor Author

yibin87 commented Jan 11, 2023

/run-verify

@yibin87
Copy link
Contributor Author

yibin87 commented Jan 11, 2023

/run-jenkins-docs-cn-verify

@yibin87
Copy link
Contributor Author

yibin87 commented Jan 11, 2023

/verify

Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shichun-0415
Copy link
Contributor

/remove status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Jan 11, 2023
@shichun-0415
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8b83d8f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 11, 2023
@ti-chi-bot ti-chi-bot merged commit de15241 into pingcap:master Jan 11, 2023
@shichun-0415 shichun-0415 added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Jan 12, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #12651.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jan 12, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
shichun-0415 added a commit that referenced this pull request Jan 12, 2023
* This is an automated cherry-pick of #12637

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* Resolve conflict

Signed-off-by: yibin <huyibin@pingcap.com>

* resolve conflict

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: yibin <huyibin@pingcap.com>
Co-authored-by: yibin <huyibin@pingcap.com>
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
@shichun-0415 shichun-0415 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bigdata Indicates that the Issue or PR belongs to the area of TiFlash, TiSpark, and OLAP. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants