Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description about tidb_auth_token authentication #11824

Merged
merged 12 commits into from
Nov 7, 2022

Conversation

CbcWestwolf
Copy link
Member

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 28, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt
  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn October 28, 2022 06:12
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 28, 2022
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 28, 2022
@qiancai qiancai added v6.4 This PR/issue applies to TiDB v6.4. translation/doing This PR’s assignee is translating this PR. labels Oct 28, 2022
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Oct 28, 2022
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 28, 2022
@Oreoxmt Oreoxmt requested review from Oreoxmt and removed request for TomShawn October 28, 2022 06:27
@Oreoxmt Oreoxmt self-assigned this Oct 28, 2022
@Oreoxmt Oreoxmt added area/security Relates to TiDB security and privilege. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. labels Oct 28, 2022
CbcWestwolf and others added 2 commits November 1, 2022 12:16
Co-authored-by: xhe <xw897002528@gmail.com>
@CbcWestwolf CbcWestwolf requested a review from xhebox November 1, 2022 04:19
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 1, 2022
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Co-authored-by: Aolin <aolinz@outlook.com>
@Oreoxmt Oreoxmt requested a review from shichun-0415 November 1, 2022 05:41
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 1, 2022
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Nov 2, 2022
@Oreoxmt Oreoxmt added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 2, 2022
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Nov 2, 2022

DNM until #11716 is merged

@@ -193,7 +193,8 @@ mysql> SELECT * FROM t1;
- 作用域:GLOBAL
- 是否持久化到集群:是
- 默认值:`mysql_native_password`
- 可选值:`mysql_native_password`,`caching_sha2_password`,`tidb_sm3_password`
- 可选值:`mysql_native_password`,`caching_sha2_password`,`tidb_sm3_password`,`tidb_auth_token`
- `tidb_auth_token` 认证方式仅用于 TiDB Cloud 内部实现,**不要设置为该值**。
- 服务器和客户端建立连接时,这个变量用于设置服务器对外通告的默认身份验证方式。如要了解该变量的其他可选值,参见[可用的身份验证插件](/security-compatibility-with-mysql.md#可用的身份验证插件)。
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

只是记录下:这个变化应该不需要体现到 TiDB v6.4.0 release notes 里,对用户看起来没有实际的作用

@@ -323,6 +323,24 @@ TiDB 配置文件比命令行参数支持更多的选项。你可以在 [config/
+ 默认值:"",支持 TLSv1.1 及以上版本。
+ 可选值:`"TLSv1.0"`、`"TLSv1.1"`、`"TLSv1.2"` 和 `"TLSv1.3"`

Copy link
Collaborator

@qiancai qiancai Nov 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

只是记录下:这两个配置项变化应该不需要体现到 TiDB v6.4.0 release notes 里,对用户看起来没有实际的作用

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Nov 7, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 80f2d0b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 7, 2022
@Oreoxmt Oreoxmt removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2022
@ti-chi-bot ti-chi-bot merged commit 791a1fb into pingcap:master Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/security Relates to TiDB security and privilege. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.4 This PR/issue applies to TiDB v6.4.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants