Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: add flashback cluster doc #11443

Merged
merged 32 commits into from
Nov 4, 2022
Merged

sql: add flashback cluster doc #11443

merged 32 commits into from
Nov 4, 2022

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Sep 28, 2022 •
edited by Oreoxmt
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 28, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt
  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn September 28, 2022 15:34
@Defined2014 Defined2014 changed the title sql: add flashback cluster doc [WIP] sql: add flashback cluster doc Sep 28, 2022
@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 28, 2022
@Defined2014 Defined2014 force-pushed the flashback-doc branch 3 times, most recently from b83808d to f6f649b Compare September 28, 2022 15:53
@shichun-0415 shichun-0415 added translation/doing This PR’s assignee is translating this PR. v6.4 This PR/issue applies to TiDB v6.4. and removed missing-translation-status This PR does not have translation status info. labels Sep 29, 2022
@shichun-0415
Copy link
Contributor

Hi @Defined2014. Since this feature is expected to be released in v6.4, do we have an FD jira issue for it? I didn't find one in the v6.4 FD list.

@Defined2014
Copy link
Contributor Author

Hi @Defined2014. Since this feature is expected to be released in v6.4, do we have an FD jira issue for it? I didn't find one in the v6.4 FD list.

@shichun-0415 The FD number is 943.

@Oreoxmt Oreoxmt requested review from Oreoxmt and removed request for TomShawn September 29, 2022 02:05
@Oreoxmt Oreoxmt added the area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. label Sep 29, 2022
@Oreoxmt Oreoxmt self-assigned this Sep 29, 2022
@Defined2014 Defined2014 mentioned this pull request Sep 29, 2022
Closed
20 tasks
@Defined2014 @Oreoxmt
Apply suggestions from code review
33a88c3 
Co-authored-by: Aolin <aolin.zhang@pingcap.com>
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Nov 1, 2022

@bb7133 @JmPotato PTAL again

shichun-0415
shichun-0415 approved these changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@Oreoxmt @shichun-0415
Apply suggestions from code review
e1879fb 
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
Oreoxmt
Oreoxmt approved these changes Nov 1, 2022
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Oreoxmt Oreoxmt removed the status/require-change Needs the author to address comments. label Nov 1, 2022
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 4, 2022
Oreoxmt
Oreoxmt reviewed Nov 4, 2022
View reviewed changes
Oreoxmt
Oreoxmt reviewed Nov 4, 2022
View reviewed changes
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 4, 2022
Oreoxmt
Oreoxmt reviewed Nov 4, 2022
View reviewed changes
Oreoxmt
Oreoxmt reviewed Nov 4, 2022
View reviewed changes
@Oreoxmt Oreoxmt requested a review from shichun-0415 November 4, 2022 06:52
shichun-0415
shichun-0415 approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Oreoxmt Oreoxmt removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2022
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Nov 4, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4e33413

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 4, 2022
@ti-chi-bot ti-chi-bot merged commit cb429f0 into master Nov 4, 2022
@Defined2014 Defined2014 deleted the flashback-doc branch November 24, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@bb7133 bb7133 bb7133 approved these changes

@JmPotato JmPotato JmPotato approved these changes

@shichun-0415 shichun-0415 shichun-0415 approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.4 This PR/issue applies to TiDB v6.4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Defined2014 @ti-chi-bot @shichun-0415 @Oreoxmt @bb7133 @JmPotato