Skip to content
This repository was archived by the owner on Nov 24, 2023. It is now read-only.

Commit

Permalink
address comment
Browse files Browse the repository at this point in the history
  • Loading branch information
lance6716 committed Oct 18, 2021
1 parent c32c4cb commit 700a0b5
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 1 addition & 1 deletion relay/relay.go
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ func NewRealRelay(cfg *Config) Process {
}

// Init implements the dm.Unit interface.
// NOTE these errors will make DM-worker exit when it boots up and assigned relay.
// NOTE when Init encounters an error, it will make DM-worker exit when it boots up and assigned relay.
func (r *Relay) Init(ctx context.Context) (err error) {
return reportRelayLogSpaceInBackground(ctx, r.cfg.RelayDir)
}
Expand Down
2 changes: 0 additions & 2 deletions tests/new_relay/run.sh
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@ function test_cant_dail_upstream() {

# make sure DM-worker doesn't exit
sleep 2
check_rpc_alive $cur/../bin/check_worker_online 127.0.0.1:$WORKER1_PORT

run_dm_ctl_with_retry $WORK_DIR "127.0.0.1:$MASTER_PORT" \
"query-status -s $SOURCE_ID1" \
"injected error" 1
Expand Down

0 comments on commit 700a0b5

Please sign in to comment.