This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
lightning: replace storage.Create by storage.New #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So shall we also remote the |
|
@glorv Yes after it has been removed from Dumpling. |
|
/lgtm |
|
/LGTM |
ti-srebot
approved these changes
Mar 23, 2021
|
/merge |
|
/run-all-tests |
|
@kennytm merge failed. |
|
/merge |
|
/run-all-tests |
|
@kennytm merge failed. |
|
/run-all-tests |
|
/build |
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/br
that referenced
this pull request
Mar 24, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #919 |
ti-srebot
pushed a commit
to ti-srebot/br
that referenced
this pull request
Mar 24, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-5.0 in PR #920 |
kennytm
added a commit
that referenced
this pull request
Mar 24, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: kennytm <kennytm@gmail.com>
ti-chi-bot
pushed a commit
that referenced
this pull request
Mar 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
storage.Createhas been deprecated... so let's replace the remaining two calls from Lightning.storage.Create(sendCreds=true), butskipCheckPath=false, which leads to #898.What is changed and how it works?
Changed
storage.Createtostorage.Newwith sendCreds=false and skipCheckPath=true.Check List
Tests
Code changes
Side effects
Related changes
Release Note
s3:ListBucketpermission on the entire bucket, only the data source prefix itself.