Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

*: report error if service safe point check fails (#825) #826

Merged
merged 2 commits into from
Mar 9, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Mar 9, 2021

cherry-pick #825 to release-4.0
You can switch your code base to this Pull Request by using git-extras:

# In br repo:
git pr https://github.com/pingcap/br/pull/826

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/br.git pr/826:release-4.0-1a5c9e5dc3ad

What problem does this PR solve?

Close #823

Report error if service safe point check fails

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release Note

  • Report error if service safe point check fails

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@3pointer
Copy link
Collaborator

3pointer commented Mar 9, 2021

/lgtm

@ti-srebot ti-srebot added the status/LGT1 LGTM1 label Mar 9, 2021
@glorv
Copy link
Collaborator

glorv commented Mar 9, 2021

/lgtm

@ti-srebot ti-srebot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Mar 9, 2021
@glorv
Copy link
Collaborator

glorv commented Mar 9, 2021

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@YuJuncen
Copy link
Collaborator

YuJuncen commented Mar 9, 2021

checksum mismatched remote vs local => (checksum: 789803659099732364 vs 3203001050118138354) (total_kvs: 2 vs 4) (#765)

/run-integration-test

@glorv
Copy link
Collaborator

glorv commented Mar 9, 2021

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added status/LGT3 LGTM3. This PR looks very good to our bot. and removed status/LGT2 LGTM2 labels Mar 9, 2021
@overvenus overvenus merged commit 46c5999 into pingcap:release-4.0 Mar 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants