Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

backup: set concurrency to 1 when ratelimit enabled (#1015) #1026

Merged
merged 2 commits into from
Apr 16, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Apr 16, 2021

cherry-pick #1015 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In br repo:
git pr https://github.com/pingcap/br/pull/1026

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/br.git pr/1026:release-5.0-0576f0713cd8

What problem does this PR solve?

Fix? #1007

What is changed and how it works?

When --ratelimit was set, degenerate to sequential backing up.

Check List

Tests

Release Note

  • Fix a bug caused the real backup speed may go beyond far the --ratelimit.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@3pointer
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 LGTM1 label Apr 16, 2021
@glorv
Copy link
Collaborator

glorv commented Apr 16, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • glorv

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@YuJuncen
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ab63efc

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants