Expose missing configurations for grpc_config
and pool_threads
#296
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR addresses a few configuration-related issues:
pool_threads
configuration up to thePinecone
client instance, but for backwards compatibility it would be nice to also allow it to be passed in the call topc.Index(host='your-host', pool_threads=5)
grpc_config
as a keyword param when targeting indexes via the grpc-flavored client.Solution
.Index()
to underlying Index class implementationpool_threads
andgrpc_config
handled correctly.Before (pool_threads)
After (pool_threads, add backwards compatibility with old way)
You can use syntax as before, or alternatively can do this:
After (grpc, allow grpc_config to be passed)
Type of Change
Test Plan
New tests should be green in CI.