Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add usage.read_units in fetch/query responses #270

Merged
merged 4 commits into from
Jan 13, 2024
Merged

Add usage.read_units in fetch/query responses #270

merged 4 commits into from
Jan 13, 2024

Conversation

jhamon
Copy link
Collaborator

@jhamon jhamon commented Jan 12, 2024 •
edited
Loading

Problem

Need to update the generated core and surface usage data properly.

Solution

  • Make a few adjustments related to tag names in updated OpenAPISpec
  • Update data integration tests to assert read_units are present
  • Make adjustments to GRPC response parsing to account for the new data attributes

Type of Change

  • New feature (non-breaking change which adds functionality)

@jhamon jhamon changed the title Update core and add usage.read_units in data responses Add usage.read_units in fetch/query responses Jan 13, 2024
@jhamon jhamon requested a review from austin-denoble January 13, 2024 01:22
@jhamon jhamon marked this pull request as ready for review January 13, 2024 01:22
austin-denoble
austin-denoble approved these changes Jan 13, 2024
View reviewed changes
Copy link
Contributor

@austin-denoble austin-denoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

pinecone/grpc/utils.py
_check_type=False
)

def parse_usage(response):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the parsing still needed if it's an int, or is this grpc-specific?

@jhamon jhamon merged commit 5370b09 into spruce Jan 13, 2024
64 checks passed
@jhamon jhamon deleted the jhamon/update-core branch January 13, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austin-denoble austin-denoble austin-denoble approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhamon @austin-denoble