chore (core): add comments to WhoAmIResponse fields #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comments to the `WhoAmIResponse` fields to better describe their meaning, as they can be ambiguous. The `username` field should be named `user_id` to better reflect its meaning, and `projectname` should be named `project_id` for consistency. No functional changes were made.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add comments to the
WhoAmIResponsefields to better describe their meaning, as they can be ambiguous. Theusernamefield should be nameduser_idto better reflect its meaning, andprojectnameshould be namedproject_idfor consistency. No functional changes were made.So, it can be merged as is. I hope it will help to fix any bugs with naming and prevent new bugs from arising in the future.
Take a look #154 (comment)