Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NewsLinkGenerator.php #560

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Update NewsLinkGenerator.php #560

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c998a2c
Update NewsLinkGenerator.php
kaurov Dec 19, 2023
e6283da
extract IF
kingjia90 Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 23 additions & 12 deletions src/Website/LinkGenerator/NewsLinkGenerator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
* Full copyright and license information is available in
* LICENSE.md which is distributed with this source code.
*
* @copyright Copyright (c) Pimcore GmbH (http://www.pimcore.org)
* @license http://www.pimcore.org/license GPLv3 and PEL
* @copyright Copyright (c) Pimcore GmbH (http://www.pimcore.org)
* @license http://www.pimcore.org/license GPLv3 and PEL
*/

namespace App\Website\LinkGenerator;
Expand All @@ -25,8 +25,14 @@
use Pimcore\Twig\Extension\Templating\PimcoreUrl;
use Symfony\Component\HttpFoundation\RequestStack;

/**
* Generates URI links for News Data-Objects
* @todo stop using direct ID. You can use slug field or at least UUID
*/
class NewsLinkGenerator implements LinkGeneratorInterface
{
const DEFAULT_DOCUMENT = 'news_default_document';

/**
* @var DocumentResolver
*/
Expand Down Expand Up @@ -79,23 +85,28 @@ public function generate(object $object, array $params = []): string
}

$localeUrlPart = '/' . $this->localeService->getLocale() . '/';
if ($document && $localeUrlPart !== $document->getFullPath()) {
$fullPath = substr($document->getFullPath(), strlen($localeUrlPart));
}

if ($document && !$fullPath) {
$fullPath = $document->getProperty('news_default_document') ? substr($document->getProperty('news_default_document')->getFullPath(), strlen($localeUrlPart)) : '';
if ($document) {
if ($localeUrlPart !== $document->getFullPath()) {
$fullPath = substr($document->getFullPath(), strlen($localeUrlPart));
}
if (!$fullPath) {
$fullPath = $document->getProperty(static::DEFAULT_DOCUMENT) ? substr($document->getProperty(static::DEFAULT_DOCUMENT)->getFullPath(), strlen($localeUrlPart)) : '';
}
}
if (!$fullPath) {
throw new \InvalidArgumentException('Set parameter '.static::DEFAULT_DOCUMENT.' for the root or current document.');
}

$locale = $params['locale'] ?? null;

return $this->pimcoreUrl->__invoke(
[
'newstitle' => Text::toUrl($object->getTitle($locale) ? $object->getTitle($locale) : 'news'),
'news' => $object->getId(),
'path' => $fullPath,
'_locale' => $locale,
],
'newstitle' => Text::toUrl($object->getTitle($locale) ? $object->getTitle($locale) : 'news'),
'news' => $object->getId(),
'path' => $fullPath,
'_locale' => $locale,
],
'news-detail',
true
);
Expand Down
Loading