-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.1.0 #81
2.1.0 #81
Conversation
@wesleytodd What about #59? The other packages updated the |
I know they did, and I think we reached a consensus that they shouldn't have. expressjs/discussions#286 (comment) Let me know if you read that differently. |
But you just included a |
I'm good with either approach—just happy to see this release go out and clean up some legacy code along the way! |
Ah, I didn't catch that as I was reading through that release PR. Too much trust in the approvals and too much time since I last looked at the content. My bad. The agreement was for sure those shouldn't have landed, but now that I published the only fix would be a fast follow patch to remove it again. @ctcpip thoughts on that? Should we back that out in a fast patch? Either way I don't think repeating the mistake here is a good idea. I would rather back out that PR that landed than release this also with the breaking engines field change. |
@wesleytodd Hey, I just realised that we forgot to update all dependencies to use caret notation. I opened #82 maybe we can include it in this release. |
c8b601b
to
c1832e0
Compare
Rebased on top of the last two merged PRs. I think this is ready to go now. |
c1832e0
to
e08969b
Compare
Noticed I missed the history entry on that last update. Added it to the version commit. Publishing now. |
also of note: I am going to switch from |
What's Changed
readable-stream
by @Phillip9587 in cleanup: remove unnecessary devDependencyreadable-stream
#67safe-buffer
by @Phillip9587 in cleanup: remove unnecessary devDependencysafe-buffer
#68ServerResponse.headersSent
support check by @Phillip9587 in refactor: removeServerResponse.headersSent
support check #77setImmediate
support check by @Phillip9587 in cleanup: removesetImmediate
support check #73debug
to ^4.4.0 by @Phillip9587 in chore(deps): updatedebug
to ^4.4.0 #78replaceAll
instead ofreplace
with a regex by @Phillip9587 in refactor: usereplaceAll
instead ofreplace
with a regex #80New Contributors
readable-stream
#67Full Changelog: v2.0.0...v2.1.0