Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix @manipulate for upcoming base changes #46

Merged
merged 2 commits into from
Aug 16, 2021
Merged

fix @manipulate for upcoming base changes #46

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
feb019b
fix `@manipulate` for upcoming base changes
simeonschaub Aug 12, 2021
e16beaa
fix
simeonschaub Aug 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/manipulate.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,12 @@ macro manipulate(args...)
" [<variable>=<domain>,]... <expression> end")
end
block = expr.args[2]
# remove trailing LineNumberNodes from loop body as to not just return `nothing`
# ref https://github.com/JuliaLang/julia/pull/41857
if Meta.isexpr(block, :block) && block.args[end] isa LineNumberNode
pop!(block.args)
end

if expr.args[1].head == :block
bindings = expr.args[1].args
else
Expand Down