Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: AFV improvements, volume + mute radio controls & minor fixes #249

Closed
wants to merge 22 commits into from
Closed

fix: AFV improvements, volume + mute radio controls & minor fixes #249

wants to merge 22 commits into from

Conversation

GeorgeBarlow
Copy link
Collaborator

@GeorgeBarlow GeorgeBarlow commented Jan 2, 2025 •
edited
Loading

Improvements:

GeorgeBarlow and others added 22 commits December 29, 2024 15:56
@GeorgeBarlow
Improve for windows
0f0ebc5
@GeorgeBarlow
Improve for windows
a7066f1
@GeorgeBarlow
Merge branch 'improv-build-system' of github.com:pierr3/TrackAudio in…
eb8d478 
…to improv-build-system
@GeorgeBarlow
Custom afv url
5b3a19d
@GeorgeBarlow
Improve test
b145e16
@GeorgeBarlow
Improve
3c55783
@GeorgeBarlow
Improve
c64d2d0
@GeorgeBarlow
Improve
fc22282
@GeorgeBarlow
Improve
7ca0871
@GeorgeBarlow
Add output gain + mute to sdk
85b6641
@GeorgeBarlow
Add changes
9425185
@GeorgeBarlow
Fix
e3b835e
@GeorgeBarlow
Fixes
49196f9
@GeorgeBarlow
Rename gain to volume, because that's the more common name
c138cd1 
move the conversion from volume to gain (/ 100) to the backend
@GeorgeBarlow
Rename config, session and local storage values from gain to volume
54bfa1e
@GeorgeBarlow
Use the stationVolume for SetFrequencyRadioVolume als percent of the …
2685bd3 
…mainRadioVolume
@GeorgeBarlow
Save stationVolumes to UserSession
221fce9 
Update RadioGain by using mainVolume and stationVolume and use stationVolume a percent of the mainVolume
Centralize the setting of the radioVolumes in the RadioHelper
@GeorgeBarlow
Fix loading mainRadioVolume from config
a734f76
@GeorgeBarlow
Add volume per station without reset button, because the volume is no…
7b979ad 
…w percentage of the main volume/gain
@GeorgeBarlow
Add that the stationVolume is forced to 100%, if tx is activated.
7b9b7c2
@GeorgeBarlow
Readd removed build files
a665808
@GeorgeBarlow
Add full integration between PR242 and websocket volume support
b09c31c
neilenns
neilenns suggested changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@neilenns neilenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lotta stuff in this PR. I focused on the backend/SDK changes, I didn't look at the UI changes.

@GeorgeBarlow GeorgeBarlow deleted the pr242-volume-gain branch January 2, 2025 22:40
@GeorgeBarlow GeorgeBarlow restored the pr242-volume-gain branch January 2, 2025 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilenns neilenns neilenns requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GeorgeBarlow @neilenns