Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request PID C55D for ch55xduino hid device #592

Merged
merged 2 commits into from
Dec 16, 2020

Conversation

DeqingSun
Copy link
Contributor

ch55xduino is a fork of open-sourced project sduino with LGPL license. It has been iterated for many versions.

@tannewt
Copy link
Collaborator

tannewt commented Dec 6, 2020

Please fix the CI. You'll need to add an org page too.

@DeqingSun
Copy link
Contributor Author

Please fix the CI. You'll need to add an org page too.

@tannewt This is the second PID we applied. The org page is already merged.

@tannewt
Copy link
Collaborator

tannewt commented Dec 16, 2020

Your owner name in this file must be wrong then. The CI will pass when it is correct.

@DeqingSun
Copy link
Contributor Author

Thanks. I was comparing the 2 local files between the C550 and C55D. They both have space in the org name.
And then I realized the C550 one was fixed in #554.

Now the space was removed.

Copy link
Collaborator

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks! I didn't realize I fixed it. :-)

@tannewt tannewt merged commit 831f21d into pidcodes:master Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants