Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sinara/stabilizer: add org and pid #552

Merged
merged 1 commit into from
Oct 26, 2020
Merged

sinara/stabilizer: add org and pid #552

merged 1 commit into from
Oct 26, 2020

Conversation

jordens
Copy link
Contributor

@jordens jordens commented Sep 6, 2020

  • org/Sinara: add Sinara organization
  • 1209/392F: add Stabilizer PID

Signed-off-by: Robert Jördens rj@quartiq.de

@jordens jordens changed the title sinara/srabilizer: add org and pid sinara/stabilizer: add org and pid Sep 6, 2020
@tannewt tannewt mentioned this pull request Sep 15, 2020
Merged
50 tasks
tannewt
tannewt requested changes Oct 20, 2020
View reviewed changes
Copy link
Collaborator

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a license file at the source location to clear document it's license.

@jordens
Copy link
Contributor Author

jordens commented Oct 20, 2020

Added in
sinara-hw/Stabilizer@0b9de4e (hardware design)
Already existing for software (https://github.com/quartiq/stabilizer/blob/master/LICENSE)

@jordens jordens requested a review from tannewt October 20, 2020 09:38
tannewt
tannewt approved these changes Oct 21, 2020
View reviewed changes
Copy link
Collaborator

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

tannewt
tannewt reviewed Oct 26, 2020
View reviewed changes
Copy link
Collaborator

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, the CI hasn't run on this. Can you force push again? I think that will trigger it.

@jordens
sinara/stabilizer: add org and pid
64f54fe 
* org/Sinara: add Sinara organization
* 1209/392F: add Stabilizer PID

Signed-off-by: Robert Jördens <rj@quartiq.de>
@jordens
Copy link
Contributor Author

jordens commented Oct 26, 2020

rebased

@tannewt
Copy link
Collaborator

tannewt commented Oct 26, 2020

Thanks!

@tannewt tannewt merged commit edfa727 into pidcodes:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jordens @tannewt