Check Open Graph via html-proofer #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Data cleanse - correct owner names and strip errant spaces (pidcodes#176)
Resync with master
Escape the colons in the title (pidcodes#180)
Resync with master
Resync with master
|
Progress on #184 . |
|
There may be one edge case with this, the checks may fail for a PR against a new PID, as the "external" URL in the Open Graph won't be valid, as the PR hasn't been approved yet. I might need to flag it as an internal link or something. |
|
Sorry, just saw this; reviewing now. |
|
My edge case prediction was correct, but as we currently don't care about external links, it doesn't (yet) break things, making it internal should fix it: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.