Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added copy address icon & functionality on displayAddress #398

Closed
wants to merge 2 commits into from
Closed

added copy address icon & functionality on displayAddress #398

wants to merge 2 commits into from

Conversation

gabrieltemtsen
Copy link
Contributor

poidh_demo

@vercel Vercel
Copy link

vercel bot commented Nov 21, 2024

@gabrieltemtsen is attempting to deploy a commit to the pics or it didn't happen's projects Team on Vercel.

A member of the Team first needs to authorize it.

@vercel Vercel
Copy link

vercel bot commented Nov 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
database-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 8:39pm

yukigesho
yukigesho reviewed Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@yukigesho yukigesho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this way, we impact all addresses. I suggest moving the copy as a separate component and reusing it

@gabrieltemtsen
Copy link
Contributor Author

In this way, we impact all addresses. I suggest moving the copy as a separate component and reusing it

Alright!

@gabrieltemtsen
Copy link
Contributor Author

In this way, we impact all addresses. I suggest moving the copy as a separate component and reusing it

@yukigesho how do you see these below
image
image

@gabrieltemtsen
Copy link
Contributor Author

In this way, we impact all addresses. I suggest moving the copy as a separate component and reusing it

@yukigesho here I just added an optional prop to displayAddress to either show the copyAddressIcon or not, so we could get a better look
image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yukigesho yukigesho yukigesho left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabrieltemtsen @yukigesho