Copy + past icon for addresses in bounty cards #131 #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st function for successful copy to clipboard
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy + past icon for addresses in bounty cards #131
Description
In response to #131 I have added copy and paste functionality to allow a user to copy the issuer's address to their clipboard. Additionally a toast message will appear on screen on successful copying of the address. Should an error occur, then a toast message will show up letting the user know that there was an issue copying the address.
Please see attached files for example of feature in action.
Type of Change
Please check the type of change your pull request introduces:
How Has This Been Tested?
The only testing I have done is inspected the feature by inspecting the functionality on my localhost. I have tried on multiple bounty cards and have not encountered any errors. I have not tested the feature on Mobile, but believe it will still operate as it should on desktop. Let me know if you need me to test mobile, and I will do that and then resubmit the pull request.
Related Issues
N/A
Additional Information
I had the option between a 3rd party library, document.execCommand and navigator.clipboard and figured for simplicity, and accessibility for browsers that navigator.clipboard would suffice. I am willing to revisit either of these options should I need to revise this code.
I have checked to see compatibility around browsers for the feature via canIUse and feel this feature is compatible with most modern browsers users would use.