Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests in a docker container #342

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Run tests in a docker container #342

merged 2 commits into from
Sep 20, 2024

Conversation

jcapona
Copy link
Contributor

@jcapona jcapona commented Sep 17, 2024

Status Ticket/Issue
Ready/Hold Ticket

Main changes

Screenshots (feature, test output, profiling, dev tools etc)

[insert screenshots here]

Other notes (e.g. implementation quirks, edge cases, questions / issues)

Manual testing tips

Tag anyone who definitely needs to review or help

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.47%. Comparing base (74f332e) to head (17673c7).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #342      +/-   ##
==========================================
- Coverage   88.92%   88.47%   -0.45%     
==========================================
  Files          68       69       +1     
  Lines        3015     3081      +66     
==========================================
+ Hits         2681     2726      +45     
- Misses        334      355      +21     
Flag Coverage Δ
python-tests 88.47% <ø> (-0.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jcapona jcapona force-pushed the SWE-321-fix-test-runs branch from 6fa106a to 6f3633f Compare September 18, 2024 15:24
@jcapona jcapona changed the title Install system dependencies for test runs on CI Run tests in a docker container Sep 18, 2024
@jcapona jcapona marked this pull request as ready for review September 18, 2024 16:08
@jcapona jcapona merged commit af72bb1 into master Sep 20, 2024
7 checks passed
@jcapona jcapona deleted the SWE-321-fix-test-runs branch September 20, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants