Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Dependency font-awesome 5.6.3 => 5.11.2 #1021

Merged
merged 2 commits into from
Oct 20, 2019
Merged

Updated Dependency font-awesome 5.6.3 => 5.11.2 #1021

merged 2 commits into from
Oct 20, 2019

Conversation

Pazekal90
Copy link
Contributor

Signed-off-by: Pazekal90 mail@pascal-pischel.de

By submitting this pull request, I confirm the following: {please fill any appropriate checkboxes, e.g: [X]}

{Please ensure that your pull request is for the 'devel' branch!}

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

Updated the dependency Font-Awesome to the latest version and tested it. No Errors.

PromoFaux and others added 2 commits September 22, 2019 00:06
@PromoFaux
Merge pull request pi-hole#1003 from pi-hole/release/v4.3.2
38d8e77 
Pi-hole Web v4.3.2
@Pazekal90
Updated Dependency font-awesome 5.6.3 => 5.11.2
1cfc5e4 
Signed-off-by: Pazekal90 <mail@pascal-pischel.de>
@DL6ER
Copy link
Member

DL6ER commented Oct 3, 2019

Could you provide a changelog for what happened between these two releases that night be interesting for us?

@Pazekal90
Copy link
Contributor Author

Pazekal90 commented Oct 3, 2019 •
edited
Loading

@DL6ER:
Changelog for the changed 5.6.3 => 5.11.2.

The most interesting changes marked in italic.
But: I think software should stay up to date with their assets even there are no "super new" features. Investigating a bug in safari version xy is way more time-expensive than keeping assets up to date.

5.11.2 - 2019-09-23

Changed

  • Updated laravel brand icon

Fixed

  • New scanner-image icon was using the same unicode value as scanner causing overlapped icons
  • The film-canister icon was incorrectly spelled film-cannister

5.11.1 - 2019-09-18

Fixed

  • Duotone icons updated in 5.11.0 had incorrect attribute order which caused
    them to fail to load for all kits

5.11.0 - 2019-09-18

Added

  • New tech, music, and western-themed icons
  • Added umbraco, swift, orcid, mdb (and one more surprise) brand icons

Fixed

  • SVG with JavaScript no longer duplicates the id attribute when in nesting mode
  • Corrected inconsistencies with the send-back and send-backward icons
  • Corrected inconsistencies with duotone icon viewBox widths that did not match
    the solid style

5.10.2 - 2019-08-22

Added

  • SVG with JS API function layers() now accepts params to add additional classes

Changed

  • Lots of updates to various duotone icons
  • Updated the keybase brand icon

Fixed

5.10.1 - 2019-08-02

Added

  • README file in the otfs/ directory to help direct folks to documentation for the new Duotone OTF file

Changed

* A lot of visual improvements and consistency fixes to many of the new Duotone icons

  • The fa-swap-opacity class now works with parent containers where Duotone icons as children

Fixed

  • Duotone SCSS files were not being correctly compiled with the Dart-Sass tool
  • Font Awesome logo was not appearing in desktop application in font pickers

5.10.0 - 2019-07-29

Added

  • Duotone icons style added with over 1,600 new icons
  • New conflict detection script to help identify conflicting versions of Font Awesome (js/conflict-detection.js)
  • Icons border-center-v and border-center-h
  • New brand icon for cotton-bureau

Changed

  • Updated version 4 shim to more accurately match sort-alpha-desc, sort-amount-desc, sort-numeric-desc

Fixed

  • Icon sort-amount-down-alt incorrectly matching sort-amount-down
  • Icon border-outer icon missing inner grid shapes

5.9.0 - 2019-06-04

Minor version upgrade notice: there are some backward-incompatible changes to this release. See the
UPGRADING.md guide for more
information.

Added

  • An assortment of voted icons, updated icons, and new icons
  • New icons and updates to the text editor category
  • A flipped version of the phone and phone-alt icon

Changed

Fixed

  • Proportions corrected on facebook-messenger brand icon

5.8.2 - 2019-05-07

Added

  • New brand icon stackpath

Changed

  • Updated redhat, mailchimp brand icons
  • Updated Facebook brand icons in accordance with https://facebookbrand.com (facebook, facebook-f, facebook-square)
  • Updated Git brand icons (git, git-square, git-alt)
  • Removing the "at" character to prevent overlap with the at icon

Fixed

5.8.1 - 2019-03-21

Fixed

  • Correct the baseline alignment of the linkedin-in brand icon

5.8.0 - 2019-03-20

Minor version upgrade notice: there are some backward-incompatible changes to this release. See the
UPGRADING.md guide for more
information.

Added

  • New sponsored icon wave-square
  • Adding new mutateApproach configuration which can force SVG with JS to render synchronously
  • Adding a round of top requested brand icons

Changed

  • Updating search terms and adding new categories
  • Removing descender-based CSS from the .fa-icon Sass mixin
  • Removed title elements from SVG sprites

Fixed

  • Fixing several icons such as spinner-third that had incorrect widths
  • Allow Sass setting for font-display to be changed
  • Missing dots in the flower icons
  • Support strict math compatibility for Less
  • Support fa-flip-both in the SVG with JS version

5.7.2 - 2019-02-12

Fixed

  • Vertical alignment issues using OTF and TTF files in desktop applications that differ from previous
    Font Awesome versions (< 5.7.0)

5.7.1 - 2019-02-01

Fixed

  • The @fortawesome/fontawesome-pro package had a corrupted SVG webfont file for the solid style
    * IE11 error reporting Promise as undefined or finally() not a function
  • The cheese has been moved on top of the patty for cheeseburger

5.7.0 - 2019-01-28

Minor version upgrade notice: there are some backward-incompatible changes to this release. See the
UPGRADING.md guide for more
information.

Added

  • New Food category
  • More Medical icons
  • More icons from the leaderboard
  • Added tasks-alt
  • New CSS class fa-flip-both that applies fa-flip-horizontal and fa-flip-vertical together
  • CSS now defaults to font-display: auto
  • Sass and Less files contain a variable that can be changed to alter the font-display value

Changed

  • Updated slack brand icon
  • Reverted calendar-alt to previous design before 5.6.0

Fixed

* Safari fails to process pseudo elements if the font-weight is "normal"

@DL6ER
Copy link
Member

DL6ER commented Oct 3, 2019

Thanks, it wouldn't have had to be that extensive.

I think software should stay up to date with their assets even there are no "super new" features. Investigating a bug in safari version xy is way more time-expensive than keeping assets up to date.

I agree and my comment was more because I'm interested in the changes to see if there is something new we can benefit from. There was never a need to justify the update as such.

My review fill follow later today when I have more time. Thanks again for your contribution!

@Pazekal90
Copy link
Contributor Author

Pazekal90 commented Oct 3, 2019 •
edited
Loading

No Problem :) I wanted to be extensive for better documentation. :)

@AzureMarker
Copy link
Contributor

AzureMarker commented Oct 3, 2019 •
edited
Loading

Base your branch on the dev branch and merge into dev, as per the contributor's guide.

@Pazekal90 Pazekal90 changed the base branch from master to devel October 3, 2019 18:02
@Pazekal90
Copy link
Contributor Author

@Mcat12 Sorry. Done that.

@AzureMarker AzureMarker merged commit 4450d74 into pi-hole:devel Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AzureMarker AzureMarker AzureMarker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Pazekal90 @DL6ER @AzureMarker @PromoFaux