-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delay immediate sync following system resume #1850
Comments
@kuraikaze OGCS already detected a system time change, which is a side effect of resuming from suspend and logged at INFO with "Detected system timezone change" - so I think we can piggyback this. 📦 Delay by a minute should now happen with hotfix v2.10.4.5.zip (see instructions for applying). Let me know how it goes. |
Ah, 'k - that would explain why OGCS only displayed the error behaviour if the system had slept for more than one hour. |
Nearly there ... Got an OGCS popup with a different error this time:-
Then the same Windows Notification error triggered:-
However - a successful sync triggered 60 seconds afterwards, so that bit worked nicely. 👍 Of course I forgot to turn back on detailed logging when I applied the hotfix sigh |
Hrmmm - no OGCS popup on next sleep/resume cycle, but a Windows Notification "Issue encountered" was triggered. The time zone change was detected and the next sync scheduled for 60 seconds later. Resume event is at 2024-04-28 17:36:15,244: OGcalsync.log 2.10.4.5-hotfix |
I think the scheduled syncs are still firing too quickly before being able to get in and delay them. 📦 I taken a slightly different approach with hotfix v2.10.4.8.zip so please let me know how that goes (see instructions for applying). |
This seems to work well for me - no popups or notifications generated, and sync completed successfully 60 seconds after resume event. Nice one 👍
Full OGcalsync.log uploaded for reference - Resume event at 024-05-03 12:58:58,342 : OGcalsync.log 2.10.4.8-hotfix |
Perfect, that's great news! Thanks for confirming 👍🏻 |
Is your feature request related to a problem? Please describe.
As per #1836 (comment), when a system resumes from suspend/hibernate, often OGCS can attempt to sync before the networking is available.
Describe the solution you'd like
For OGCS to detect the resume event and delay syncs to give the networking a chance to become usable.
The text was updated successfully, but these errors were encountered: