Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrectly reporting running multiple instances of OGCS with same configuration #1717

Closed
joshdcurry opened this issue Oct 12, 2023 · 1 comment
Assignees
Labels
bug Something's not working right waiting fix confirmation Hotfix available for testing
Milestone

Comments

@joshdcurry
Copy link

joshdcurry commented Oct 12, 2023

OGCS Version: v2.10.0.0
Edition: Portable
Sync Direction: G->O

Bug Description
Issue 1. Application reports multiple instances running with the same configuration, but the instances are being launched with different configurations via the command line and instructions at https://github.com/phw198/OutlookGoogleCalendarSync/wiki/Running-Multiple-Instances-of-OGCS.

Issue 2. You should update the instructions for multiple instances to note that using the cmd "start" requires a title or a blank double quote at the start (eg, start "" "c:\something long\run.exe") when your command line parameters have spaces in them.

Steps to Reproduce Issue 1

  1. Launch two instances with different configurations via command line. Here are the actual lines from my batch file.

start "" "C:\Curry Data\Apps\Outlook Google Calendar Sync\OutlookGoogleCalendarSync.exe" /s:"C:\Curry Data\Apps\Outlook Google Calendar Sync\CurryFamilyCal\settings_fam.xml" /l:"C:\Curry Data\Apps\Outlook Google Calendar Sync\CurryFamilyCal\OGcalsync_fam.log" /t:"Curry Family Calendar"
start "" "C:\Curry Data\Apps\Outlook Google Calendar Sync\OutlookGoogleCalendarSync.exe" /s:"C:\Curry Data\Apps\Outlook Google Calendar Sync\JoshGmailCal\settings_jdc.xml" /l:"C:\Curry Data\Apps\Outlook Google Calendar Sync\JoshGmailCal\OGcalsync_jdc.log" /t:"Josh Gmail Calendar"

  1. Notice the error window below pop up when the second command line runs

image

Steps to Reproduce Issue 2

  1. Run the batch file without double quote "" at the start of a line.

start "C:\Curry Data\Apps\Outlook Google Calendar Sync\OutlookGoogleCalendarSync.exe" /s:"C:\Curry Data\Apps\Outlook Google Calendar Sync\CurryFamilyCal\settings_fam.xml" /l:"C:\Curry Data\Apps\Outlook Google Calendar Sync\CurryFamilyCal\OGcalsync_fam.log" /t:"Curry Family Calendar"

  1. Notice error

image

  1. Resolution is to add double quote before the command "start" so you have this syntax: start "" "c:\something long\run.exe"

See resolution on this command line issue at https://www.donationcoder.com/forum/index.php?topic=33979.0#:~:text=If%20you%20want%20to%20use,title%20argument%20in%20double%20quotes.

Any other information
Logs for both configs are attached.
OGcalsync_jdc.log
OGcalsync_fam.log

@joshdcurry joshdcurry added the bug Something's not working right label Oct 12, 2023
@phw198 phw198 added the triage Issue being investigated label Oct 22, 2023
@phw198 phw198 self-assigned this Oct 22, 2023
@phw198
Copy link
Owner

phw198 commented Oct 22, 2023

Thanks for reporting this and I've updated the wiki with the start syntax change 👍

📦 Issue 1 should now be resolved with hotfix v2.10.1.10.zip (see instructions for applying).

Please let me know how it goes.

@phw198 phw198 added waiting fix confirmation Hotfix available for testing and removed triage Issue being investigated labels Oct 22, 2023
@phw198 phw198 changed the title Incorrect error reporting Running Multiple Instances of OGCS with same configuration Incorrectly reporting running multiple instances of OGCS with same configuration Oct 22, 2023
@phw198 phw198 added this to the v2.10.2 milestone Oct 26, 2023
@phw198 phw198 closed this as completed in 5e9f4a4 Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something's not working right waiting fix confirmation Hotfix available for testing
Projects
None yet
Development

No branches or pull requests

2 participants