Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Management of filtered events out from Outlook #1682

Closed
orl776 opened this issue Jul 28, 2023 · 6 comments
Closed

Management of filtered events out from Outlook #1682

orl776 opened this issue Jul 28, 2023 · 6 comments
Assignees
Labels
enhancement New feature waiting fix confirmation Hotfix available for testing
Milestone

Comments

@orl776
Copy link

orl776 commented Jul 28, 2023

Hi,
in 2.10.0 release I saw the new feature "2-way: Don’t delete from Google items that were filtered out from Outlook"
But this is causing to me some troubles.

Here is my case:

  • in order to exclude some events from sync, I label them in Outlook with a specific category named "skip"
  • I configured OGCS in order to filter out from sync such a catetogy

What I'm experiencing now is the following

  • a new invitation arrives in Outlook (so no category is set for the event)
  • the event is synced and appears in Google
  • later I decide to skip the event and set it as tentative in outlook
  • since there is no way to identify tentative events in Google, I label the event with the "skip" category in Outlook

Before the 2.10.0 OGCS filtered out the "skip" event, the Google event had no twin in Outlook anymore and OGCS prompted me to delete it in Google
Now instead the filtering seems to simply not consider the event, so I have the Outlook event with the "skip" category set but the Google calendar is still there.
I'm not sure but it seems that the category filter feature simply skips changes applied in Outlook but not the event itself in the compared list of events.

Hope to have a rollback of this feature or at least a new feature to map outlook tentative events with a specific color in google (I also added a comment to the enhancement #1254 - "Option to exclude Out Of Office, Tentative, Private calendar items")

Thanks

@orl776 orl776 added the bug Something's not working right label Jul 28, 2023
@phw198
Copy link
Owner

phw198 commented Jul 29, 2023

Thanks for raising this @orl776 - the change in behaviour came from #1083 (comment). I'll have to have a think on best way to handle both that and your situation...

Meanwhile, you may be interested in #825 which can now also filter out tentative calendar items.

@phw198 phw198 added the triage Issue being investigated label Jul 29, 2023
@phw198
Copy link
Owner

phw198 commented Jul 29, 2023

So with the ability to filter tentative/free events, this works as a "hard" delete - if an item is filtered, the synced copy gets deleted, which is the behaviour you are after.

Strictly, #1083 also wanted to filter on availability/free - but not have this sync back as a deletion.

One option could be to have a switch to drive the behaviour (delete or not to delete for filtered items), but then this would inevitably be required for every single individual filter option (all day, availability, privacy, category.....) - that way lies lots of work, confusion for users and general madness 🥴

So I think the sweet spot might be:

  • add the "delete or not to delete filtered items" option just for category filtering, as categories give the user much more flexibility over which ones they define,assign and how OGCS uses them
  • leave all other filtering options (all-day, availability, privacy...) to always delete when filtered

Thoughts @orl776 @Imbutien @ghnogueira ?

@phw198 phw198 self-assigned this Jul 29, 2023
@phw198 phw198 added enhancement New feature and removed bug Something's not working right labels Jul 29, 2023
@phw198
Copy link
Owner

phw198 commented Jul 29, 2023

📦 This should now be available with hotfix v2.10.0.9.zip (see instructions for applying).

Note:

  • the option is only available for 2-way syncs
  • the default is back to pre v2.10 behaviour and excluded items will be deleted.

Please let me know how it goes!

image

@phw198 phw198 added waiting fix confirmation Hotfix available for testing and removed triage Issue being investigated labels Jul 29, 2023
@phw198 phw198 added this to the v2.10.1 milestone Jul 30, 2023
@phw198 phw198 closed this as completed in d0594e3 Jul 30, 2023
@orl776
Copy link
Author

orl776 commented Jul 30, 2023 via email

@orl776
Copy link
Author

orl776 commented Jul 31, 2023 via email

@phw198
Copy link
Owner

phw198 commented Aug 6, 2023

Thanks @orl776 - I've raised #1686 to track this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature waiting fix confirmation Hotfix available for testing
Projects
None yet
Development

No branches or pull requests

2 participants