Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting appointments from appointment series in sync #1653

Closed
ladydi2023 opened this issue May 24, 2023 · 14 comments
Closed

Deleting appointments from appointment series in sync #1653

ladydi2023 opened this issue May 24, 2023 · 14 comments
Assignees
Labels
bug Something's not working right resolved Working hotfix available
Milestone

Comments

@ladydi2023
Copy link

Sorry, i´m german, i hope you understand my problem:

Deleted appointments from appointment series from Outlook are not deleted in the synchronization, only individual appointments are removed. Concerns sync Outlook --> Google-Calendar, "confirm deletion" ist activated.

@ladydi2023 ladydi2023 added the bug Something's not working right label May 24, 2023
@phw198
Copy link
Owner

phw198 commented May 25, 2023

Hi @ladydi2023

You mean to say deleted occurrences from an Outlook recurring series are not being removed from Google?

Please try these steps:

  1. Restart Outlook to see if that fixes the issue
  2. Try a "Full Sync" by pressing Shift and clicking Sync
  3. Upgrade OGCS and reproduce the issue on the latest latest release
  4. Provide your OGcalsync.log file (see instructions).

@phw198 phw198 added the more info needed Not enough detail provided to fully troubleshoot label May 25, 2023
@github-actions
Copy link

This issue has been marked dormant because the last update is at least 30 days ago. If no update is made with the next 7 days, the issue will be closed.

@github-actions github-actions bot added the dormant Issue has not been responded to over 30 days label Jun 25, 2023
@Kivi-Berlin
Copy link

Same here with 2.10.0

Created a series once a week in Outlook
Sync into Google: OK --> Whole series is in Google
Deleted one element of the series in Outlook
Shift Sync into Google: NOK --> Still the whole series is in Google
Deleted the whole series in Outlook
Sync into Google: OK --> whole series is deleted in Google

I forwarded the logfile to your mail address.

@github-actions github-actions bot removed the dormant Issue has not been responded to over 30 days label Jul 1, 2023
@phw198
Copy link
Owner

phw198 commented Jul 1, 2023

@Kivi-Berlin Following your steps through, it deleted the occurrence in Google for me.

Your log file has:

27.06.2023 12:00 (R) => "Series"
This is a recurring appointment with 1 exceptions that will now be iteratively compared.
Finding Google instance for deleted Outlook exception:-
Original date: 04.07.2023
Google exception event is not cached. Retrieving all recurring instances...
Retrieving all recurring event instances from Google for e7utonhajlk75tkarujo9mdthk
Page 1 received.
Matching Google Event recurrence found.
Another deleted occurrence on the same date 04-Jul-2023 found, so this Google item that has moved to that date will not be deleted.

The last line means that you deleted an occurrence, and then moved a different occurrence to the same date as the one just deleted, and then also deleted that.

That's how I've replicated the issue anyway!

  1. Created a series once a day in Outlook
  2. Sync into Google: OK --> Whole series is in Google
  3. Deleted one element of the series in Outlook, eg 30-Jun
  4. Sync into Google: OK --> 30-Jun deleted in Outlook
  5. Move the 1-Jul to the 30-Jun in Outlook
  6. Sync into Google: OK --> 1-Jul moves to 30-Jun
  7. Delete the moved 30-Jun occurrence in Outlook
  8. Sync into Google: Not OK --> Item is not deleted with log entry Another deleted occurrence on the same date 30-Jun-2023 found, so this Google item that has moved to that date will not be deleted.

The problem is, due to Outlook shortcomings, it's not possible to know which occurrence is the original after an item is moved to the same date as a previously deleted occurrence.

I think the only option here is for manual intervention and to popup a box asking the user if they want to proceed with the deletion....

@phw198 phw198 self-assigned this Jul 1, 2023
@phw198 phw198 added the triage Issue being investigated label Jul 1, 2023
@phw198
Copy link
Owner

phw198 commented Jul 1, 2023

📦 Please try with hotfix v2.10.0.1.zip (see instructions for applying) - this should now prompt if you want to delete.

Please let me know how it goes!

@phw198 phw198 added waiting fix confirmation Hotfix available for testing and removed triage Issue being investigated more info needed Not enough detail provided to fully troubleshoot labels Jul 1, 2023
@Kivi-Berlin
Copy link

@phw198 I followed the instruction and installed the fix.
I'll send the logfile in a separate mail.
Only during the first run were a lot of popups, but it did not synchronized the one removed occurrence in Outlook to Google.
Regarding the popups I suggest to consider the "Sync Settings", button "Sync Options", section "How": two checkboxes for deletions.

I didn't do that: The last line means that you deleted an occurrence, and then moved a different occurrence to the same date as the one just deleted, and then also deleted that.
I just created a series. Synced it. Removed one occurence. Synced it again.

@phw198
Copy link
Owner

phw198 commented Jul 2, 2023

In the log file, I only see

  • The "Series" being created, but then no change detected afterwards.
    • Please can you close and reopen Outlook and try another sync (sometimes Outlook is really bad at caching appointments so other programs can't "see" the change for a while).
  • The first run is just resolving the items that should have been deleted before - once gone, subsequent runs are clear
  • When I followed your steps, I can't reproduce the issue. Also your first log includes lines that are only relevant if an occurrence is moved to the date of a deleted occurrence. We need to get your "Series" change synced to determine if it gets removed silently or you get a popup...

Update: OK, I have now reproduced the issue:

  1. Follow your steps, but before you sync the deleted Outlook occurrence on date x
  2. Ensure there is a different recurring series in Google that already has an occurence on date x that is deleted/cancelled

This is certainly a bug 😞

@Kivi-Berlin
Copy link

I repeated the action to follow you advices:
Created a Google series
Synched
I closed Outlook and reopened it
I deleted the second occurence of the series
I closed Outlook and reopened it
Now OGCS did the sync fine. The second one was remove in Google
I tied it with another occurence of the series and it was also removed now from Google without restarting Outlook.

So I think the fix is well done.

@Kivi-Berlin
Copy link

I did some more checks.
There was no difference whether I did the sync between creating the series and deleting one item or after it.
It only works after I restarted Outlook.

@phw198
Copy link
Owner

phw198 commented Jul 2, 2023

Update: OK, I have now reproduced the issue:

Follow your steps, but before you sync the deleted Outlook occurrence on date x
Ensure there is a different recurring series in Google that already has an occurence on date x that is deleted/cancelled
This is certainly a bug

📦 Please test further with hotfix v2.10.0.2.zip (see instructions for applying).

Hopefully this is the full fix.

@Kivi-Berlin
Copy link

Yes. v2.10.0.2 is fine.
When you create a series and delete an occurence before the next sync, then OGCS sync the series to Google and deletes the deleted occurence in Google.
image

Minor point: If you delete another occurence from the same series after the sync, then the next sync deletes the occurence as it should. Fine so far. But there is no point in the sync output list about that.
image
It's only mentioned, if you delete the whole series.
image

@phw198
Copy link
Owner

phw198 commented Jul 2, 2023

Yes. I had been noticing the inconsistencies with the console output for series occurrence changes - I'll improve that in the next alpha release 👍

Thanks for confirming the fix!

@phw198 phw198 added resolved Working hotfix available and removed waiting fix confirmation Hotfix available for testing labels Jul 2, 2023
@phw198 phw198 added this to the v2.10.1 milestone Jul 2, 2023
@Gezzen
Copy link

Gezzen commented Jul 26, 2023

Hi, I faced the same issue, will test the hotfix. Thanks a lot for the prompt support all the time.

Something I realized, linked to this issue (probably rather a google issue):
When I deleted the entries manually in google calendar, it asks if I want to send decline notes. When clicking "No" it still sends them. I saw that ogcs adds the .ogcs to the email address, to prevent weird mails. So I assume this is known and if not mistaken for years not solved by google?

@phw198
Copy link
Owner

phw198 commented Jul 26, 2023

@Gezzen Yes, it's documented in the wiki and it's a shockingly awful bug that Google have simply refused to fix for years! OGCS is just a victim of this and the .ogcs appending is an equally "awful" workaround 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something's not working right resolved Working hotfix available
Projects
None yet
Development

No branches or pull requests

4 participants