Skip to content

Commit

Permalink
Don't add default reminder to Google if email notification(s) set.
Browse files Browse the repository at this point in the history
Fixes #1156
  • Loading branch information
phw198 committed Jan 23, 2021
1 parent 37f7274 commit ef6aa86
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/OutlookGoogleCalendarSync/GoogleOgcs/GoogleCalendar.cs
Original file line number Diff line number Diff line change
Expand Up @@ -785,7 +785,7 @@ public Event UpdateCalendarEntry(AppointmentItem ai, Event ev, ref int itemModif
} //if Google reminder found
} //foreach reminder

} else { //no Google reminders set
} else { //no Google popup reminders set
if (ai.ReminderSet && OKtoSyncReminder) {
sb.AppendLine("Reminder: nothing => " + ai.ReminderMinutesBeforeStart);
ev.Reminders.UseDefault = false;
Expand All @@ -795,7 +795,8 @@ public Event UpdateCalendarEntry(AppointmentItem ai, Event ev, ref int itemModif
ev.Reminders.Overrides = new List<EventReminder>();
ev.Reminders.Overrides.Add(newReminder);
itemModified++;
} else {

} else if (ev.Reminders.Overrides == null) { //No Google email reminders either
Boolean newVal = OKtoSyncReminder ? Settings.Instance.UseGoogleDefaultReminder : false;

//Google bug?! For all-day events, default notifications are added as overrides and UseDefault=false
Expand Down

0 comments on commit ef6aa86

Please sign in to comment.