Log WARN when no Outlook category mapping found as specified in Setti…

…ngs. Refresh Categories if null. Closes #1031
phw198 · Jul 19, 2020 · cf06337 · cf06337
1 parent 69ab73d
commit cf06337
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/OutlookGoogleCalendarSync/GoogleOgcs/GoogleCalendar.cs b/src/OutlookGoogleCalendarSync/GoogleOgcs/GoogleCalendar.cs
@@ -1440,7 +1440,6 @@ private void getOutlookCategoryColour(String aiCategories, ref OlCategoryColor?
                 try {
                     String category = aiCategories.Split(new[] { OutlookOgcs.Calendar.Categories.Delimiter }, StringSplitOptions.None).FirstOrDefault();
                     categoryColour = OutlookOgcs.Calendar.Categories.OutlookColour(category);
-                    if (categoryColour == null) log.Warn("Could not convert category name '" + category + "' into Outlook category type.");
                 } catch (System.Exception ex) {
                     log.Error("Failed determining colour for Event from AppointmentItem categories: " + aiCategories);
                     OGCSexception.Analyse(ex);

diff --git a/src/OutlookGoogleCalendarSync/OutlookOgcs/OutlookCategories.cs b/src/OutlookGoogleCalendarSync/OutlookOgcs/OutlookCategories.cs
@@ -155,10 +155,15 @@ public void BuildPicker(ref System.Windows.Forms.CheckedListBox clb) {
         /// <returns>The Outlook category type</returns>
         public Outlook.OlCategoryColor? OutlookColour(String categoryName) {
             if (string.IsNullOrEmpty(categoryName)) log.Warn("Category name is empty.");
+
+            if (this.categories == null)
+                OutlookOgcs.Calendar.Instance.IOutlook.RefreshCategories();
 
             foreach (Outlook.Category category in this.categories) {
                 if (category.Name == categoryName.Trim()) return category.Color;
             }
+
+            log.Warn("Could not convert category name '" + categoryName + "' into Outlook category type.");
             return null;
         }