Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vimscript implementation #3

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

dantleech
Copy link

@dantleech dantleech commented Mar 31, 2018

Hey :)

This PR:

  • Adjusts the plugin to use only Vimscript, taking advantage of the --errorFormat=raw option.
  • Tries to detect project versions of PHPStan, falling back to the global executable.

Todo:

  • Add some documentation.
  • Test it properly
  • Include phpstan.neon if it exists...

Initially this plugin didn't work because I didn't have phpstan installed globally, then I just thought I'd try and adopt the VIMScript approach.

@dantleech dantleech force-pushed the vimscript branch 2 times, most recently from 955f64d to e46246a Compare March 31, 2018 18:43
@akrabat
Copy link

akrabat commented Sep 14, 2018

This worked for me as I have PHPStan installed in vendor/bin/phpstan

Thanks!

@mstyles
Copy link

mstyles commented Oct 23, 2018

This sounds like a great addition, as I also have PHPStan installed at the project level. Any reason why this hasn't been merged?

@dantleech
Copy link
Author

dantleech commented Oct 24, 2018

For what it's worth, I switched to using Ale which supports Phpstan OOTB: https://github.com/w0rp/ale (works best with phpstan installed globally)

@weeman1337
Copy link

weeman1337 commented Jul 13, 2021

For what it's worth, I switched to using Ale which supports Phpstan OOTB: https://github.com/w0rp/ale (works best with phpstan installed globally)

  • Since three days ALE now picks up the local PHPStan executable if it is available
  • ALE only supports file level diagnostics while this one here loads everything into the quickfix list

This combination of both would be great :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants