Fix random_int() without args crash

phpstan · Jan 14, 2022 · 6d7ba0f · staabm · Jan 14, 2022 · 6d7ba0f
1 parent f2696a4
commit 6d7ba0f
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 2 deletions.
diff --git a/src/Rules/Functions/RandomIntParametersRule.php b/src/Rules/Functions/RandomIntParametersRule.php
@@ -11,6 +11,8 @@
 use PHPStan\Type\Constant\ConstantIntegerType;
 use PHPStan\Type\IntegerRangeType;
 use PHPStan\Type\VerbosityLevel;
+use function array_values;
+use function count;
 use function sprintf;
 
 /**
@@ -38,8 +40,13 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
-		$minType = $scope->getType($node->getArgs()[0]->value)->toInteger();
-		$maxType = $scope->getType($node->getArgs()[1]->value)->toInteger();
+		$args = array_values($node->getArgs());
+		if (count($args) < 2) {
+			return [];
+		}
+
+		$minType = $scope->getType($args[0]->value)->toInteger();
+		$maxType = $scope->getType($args[1]->value)->toInteger();
 
 		if (
 			!$minType instanceof ConstantIntegerType && !$minType instanceof IntegerRangeType

diff --git a/tests/PHPStan/Rules/Functions/RandomIntParametersRuleTest.php b/tests/PHPStan/Rules/Functions/RandomIntParametersRuleTest.php
@@ -58,4 +58,9 @@ public function testFile(): void
 		]);
 	}
 
+	public function testBug6361(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-6361.php'], []);
+	}
+
 }
diff --git a/tests/PHPStan/Rules/Functions/data/bug-6361.php b/tests/PHPStan/Rules/Functions/data/bug-6361.php
@@ -0,0 +1,5 @@
+<?php
+
+namespace Bug6361;
+
+random_int();
-Original file line number
+Diff line change
@@ Expand Up / @@ -58,4 +58,9 @@ public function testFile(): void @@
     		]);
     	}
+    	public function testBug6361(): void
+    	{
+    		$this->analyse([__DIR__ . '/data/bug-6361.php'], []);
+    	}
     }