Migrate zend_*_property APIs to accept zend_object* instead of zval* #5953
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out by @derickr, the current state of property APIs in PHP 8 is inconsistent. We've migrated large parts of the object-related API to accept
zend_object*
instead ofzval*
. However, thezend_*_property()
family of functions still accepts zvals. This leaves us in an odd situation where theread_property()
object handler acceptszend_object*
, while thezend_read_property
function acceptszval*
. This is inconsistent and causes friction in places where such APIs interact, because it may be necessary to create dummy zval wrappers.This patch changes the
zend_*_property
family of functions to requirezend_object*
as well, in line with underlying APIs.