Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid unnecessary string refcounting in ext/mbstring #17892

Merged
merged 1 commit into from
Feb 22, 2025
Merged

Avoid unnecessary string refcounting in ext/mbstring #17892

merged 1 commit into from
Feb 22, 2025

Conversation

nielsdos
Copy link
Member

No description provided.

@alexdowad
Copy link
Contributor

Thanks, @nielsdos!

@alexdowad
Copy link
Contributor

Perhaps @youkidearitai might want to have a look, though the changes are small.

youkidearitai
youkidearitai approved these changes Feb 22, 2025
View reviewed changes
Copy link
Contributor

@youkidearitai youkidearitai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nielsdos nielsdos merged commit b1841fd into php:master Feb 22, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youkidearitai youkidearitai youkidearitai approved these changes

@alexdowad alexdowad alexdowad approved these changes

Assignees
No one assigned
Labels
Extension: mbstring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nielsdos @alexdowad @youkidearitai