Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zend/tests: merge constant_expressions into constexpr, update names #17872

Merged
merged 1 commit into from
Feb 21, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Zend/tests/constexpr/new_dynamic_class_name.phpt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
--TEST--
Dynamic class name in new is not supported
Dynamic class name in new is supported
--FILE--
<?php

Expand Down
2 changes: 1 addition & 1 deletion Zend/tests/constexpr/new_invalid_operation_in_arg.phpt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
--TEST--
Invalid operation in new arg in const expr
Valid operation in new arg in const expr
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is interesting, because AFAICT it no longer is a constexpr context since https://wiki.php.net/rfc/arbitrary_static_variable_initializers

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, guess I forgot to update the test description.

--FILE--
<?php

Expand Down
2 changes: 1 addition & 1 deletion Zend/tests/constexpr/new_static.phpt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
--TEST--
Static in new is not supported
Static in new is supported
--FILE--
<?php

Expand Down
Loading