Override hardcoded stylesheets in PHP XHTML formats #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let the --css option override the default stylesheets for all PHP XHTML-based formats.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let the
--cssoption override the default stylesheets for all PHP XHTML-based formats. Closes #70.Phd's
--cssoption allows to pass stylesheets to the rendered formats. However, in the constructor of thePHP_ChunkedXHTMLformat two stylesheets fromphp.netare added to every rendering in this format.This PR changes this behaviour so that the hardcoded stylesheets are only added if there are no stylesheets passed in from the command line and it applies this to all of the XHTML-based format in the PHP package.
The default behavior (ie. without the
--cssoption) does not change for thePHP_ChunkedXHTMLformat.