Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define undefined properties and variables #186

Merged

Conversation

haszi
Copy link
Contributor

@haszi haszi commented Jan 5, 2025

Define undefined properties and variables.

I'm planning on opening one or more PRs that would address some of the smaller issues found with static analysis before I try to make larger changes (such as adding parameter and return types). If anyone has any objections to this, please let me know.

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSTM, but I wonder if we shouldn't be removing some of the packages/styles (I have no idea why PEAR would be used anymore)

@Girgias Girgias merged commit 92dd87a into php:master Jan 5, 2025
7 checks passed
@haszi haszi deleted the Define-undefined-properties-and-variables branch January 12, 2025 16:20
@haszi
Copy link
Contributor Author

haszi commented Jan 12, 2025

MSTM, but I wonder if we shouldn't be removing some of the packages/styles (I have no idea why PEAR would be used anymore)

This would make sense. I'm not sure whether the libraries the PDF formats (Haru) and the format highlighters (GeSHi) are based on are still being maintained but those could probably be dropped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants