Refactor Config #182
Refactor Config #182
Conversation
Remove methods mapping method calls to property access
Remove superfluous exportable() method
Add getter for color output Remove superfluous set_color_output() method Add code related to color output on windows to the constructor
Make copyright a readonly property that is initialized in the constructor Remove copyright() method
phpdotnet/phd/Config.php
Outdated
| /** @var array<string, string> */ | ||
| public array $output_format = []; |
There was a problem hiding this comment.
Is the change from static to instance properties okay? (not that I think having it static in the first place made a lot of sense).
There was a problem hiding this comment.
I think it makes sense that one set of configuration options can be assigned to one object of the class Config and then we just pass the appropriate object when needed.
As far as how Config is used in PhD, this doesn't make much of a difference as only one Config object is used throughout. :-)
I wanted to do this eventually but it makes more sense to do this as part of this PR. |
I'll leave it up to you to merge it as you want. |
This PR refactors the
Configclass from using an array of options and method calls to access these to mostly using object properties. Probably best reviewed commit by commit.